Snippet GetPlayer

[Azlier]

Everybody loves the Player native, right? Well, this is faster. And it doesn't crash when you provide invalid integers. Also includes LocalPlayer, which is magic.

How magical.

library GetPlayer initializer Init

globals
    private player array Players
    private player theLocalPlayer
endglobals

constant function GetPlayer takes integer i returns player
     return Players<i>
endfunction

constant function LocalPlayer takes nothing returns player
    return theLocalPlayer
endfunction

private function Init takes nothing returns nothing
    local integer i = 15
    loop
        exitwhen i &lt; 0
        set Players<i> = Player(i)
        set i = i - 1
    endloop
    set theLocalPlayer = GetLocalPlayer()
endfunction

endlibrary
</i></i>

 

[Romek]

Is this a joke?

 

[Azlier]

Partially, yes. But I actually use this.

 

[Romek]

Here's another thing you might add:

globals
  player LocalPlayer = GetLocalPlayer()
endglobals

Anyway, I'll graveyard this simply because it's far too simple to be a snippet. There's nothing that requires much thought here, and it's probably faster to actually write this yourself than to find this and copy it into a map.

 

[Azlier]

Nobody ever thinks of replacing Player.

Besides, your global crashes. My local player does not.

 

[Romek]

15:34	Azlier	Your global crashes, Romek.
15:34	Azlier	
15:34	Romek	Does it?
15:35	Romek	Meh.
15:35	Azlier	Indeed it does.
15:35	Romek	Set it at map init.

 

[Azlier]

Mine already does that.

The sad part is that LocalPlayer is an inlining function, instead of just a global.

 

[Troll-Brain]

I wouldn't bet Player(X) is slower than reading a player array, maybe it's just as fast as reading a global player array, or even slightly faster, that would explain the crash when you use an invalid number (no checks at all).

And for GetLocalPlayer, against, it "needs" to be proofed.

 

[Renendaru]

I actually use something like this too. I needed to get the selected unit dynamically if it changes, so I had to set a global array for each player.

 

[Azlier]

>I wouldn't bet Player(X) is slower than reading a player array

Player(x) is native I2H. Isn't GetHandleId (etc.) slower than an array call?

 

[Troll-Brain]

Player(x) is native I2H.

And how you know it ?

 

[Jesus4Lyf]

Player(x) is not native I2H.

 

[Troll-Brain]

Player(x) is not native I2H.

And how you know it ?

Guys, some explanations before giving statements, wouldn't be that much useless xD

 

[Romek]

if [ljass]I2P/*Player*/(0) == Player(0)[/ljass] and [ljass]I2P(15) == Player(15)[/ljass]; then I guess it is just a type-safe I2H.

I'm not going to be testing that, though I wouldn't be surprised if that is indeed the case.

 

[Jesus4Lyf]

Ugh.

For starters, native I2H functions NEVER fatal, because they just return the value passed in as a handle.

Then player is an agent, and native I2H functions never return agents.

Then you could do a simple CHECK...

    call BJDebugMsg(I2S(GetHandleId(Player(0)))) // Result: 1048584
    call BJDebugMsg(I2S(GetHandleId(Player(0))-0x100000)) // Result: 8

... and find that hey look, the result is not 0. Obviously it is not native I2H.

 

[Azlier]

So I was lied to... again? Blargh.

We might need benchmarks. This vs. Player.

 

[Renendaru]

So I was lied to... again? Blargh.

We might need benchmarks. This vs. Player.

Azy, you amuse us all.

 

[Jesus4Lyf]

I thought I'd have taught you not to listen by now!

 

[Azlier]

>I thought I'd have taught you not to listen by now!
I refuse to listen to such nonsense!

>Azy, you amuse us all.
I'm so glad.

 

[Jesus4Lyf]

Benchmark it.
I bet the array read is faster than Player.