Snippet GetPlayer

[Azlier]

I would think so, too.

I can't get benchmark natives to work.

 

[Troll-Brain]

I can't neither, because my "NewGen Warcraft.exe" crash when i try to load it.

Can we use the stopwatch custom natives with something else ?

 

[Nestharus]

What's sad is I had already submitted something exactly like this and it was graveyarded and never looked at it again... except that mine is better because it keeps players updated through out the game and indexes them so you can loop through all current players efficiently.

It also split up playing players and computer players so that you wouldn't have to split it up yourself..

Oh well : \. There's no justice in the world is there.

 

[Azlier]

>something exactly like this
Mine is one function. Yours is a bunch of functions with names that don't fit the Blizzard style.

PTN_GET_PLAYER isn't an easy change compared to just adding the Get before Player.

I also looked at the code. Lots of things I see wrong, especially the requirement of BoolexprUtils.

 

[Jesus4Lyf]

>What's sad is I had already submitted something exactly like this and it was graveyarded and never looked at it again...
This resource was graveyarded faster than yours. The fact that it got user interest is not our responsibility. What's your point?

 

[Azlier]

New benchmarks are needed.

private function Actions takes nothing returns nothing
    local integer watch1
    local integer watch2
    local integer loop1 = 5000
    local integer loop2 = 5000
    local real result1 = 0
    local real result2 = 0
    local player p
    set watch1 = StopWatchCreate()
    loop
        set p = GetPlayer(0)
        set result1 = result1 + StopWatchMark(watch1)
        exitwhen loop1 == 0
        set loop1 = loop1 - 1
    endloop
    call StopWatchDestroy(watch1)
    call TriggerSleepAction(0)
    set watch2 = StopWatchCreate()
    loop
        set p = Player(0)
        set result2 = result2 + StopWatchMark(watch2)
        exitwhen loop2 == 0
        set loop2 = loop2 - 1
    endloop
    call StopWatchDestroy(watch2)
    call BJDebugMsg("GetPlayer: " + R2S(result1 * 10))
    call BJDebugMsg("Player: " + R2S(result2 * 10))
endfunction

 

[Jesus4Lyf]

Owned.

Good to put it to rest.
Thanks for the test.

What about GetLocalPlayer vs global LocalPlayer?

 

[cleeezzz]

wow thats suprising O-o

 

[Renendaru]

Well, I found one thing through the tests, Azlier's array lookup is faster than Player() when it is lagging.

 

[Lyerae]

wow thats suprising O-o

Indeed.

Pwnt.

 

[cleeezzz]

-.- lol

also weird, lagging should slow the array lookup proportionally right =/

 

[Renendaru]

-.- lol

also weird, lagging should slow the array lookup proportionally right =/

This is what I originally thought, but after awhile of purposely stacking handles, GetPlayer() was about 567.432, while Player() was 1123.49.

 

[Azlier]

How many handles are we talking?

 

[Renendaru]

I just spammed handles using CreateUnit, special effects everywhere, and whatnot. I would say around... Alot? I didn't have a(n) *inefficient* handle counter.

 

[Azlier]

Use a handle counter.

Err. New results show that this is faster 70% of the time. How weird.

 

[Renendaru]

Well I did a full re-test on an empty map and I must say, the results were unexpected. Azlier's GetPlayer returned the lowest value 7/10 times... Here's a screenie of one of them.

 

[Jesus4Lyf]

Is this for 1000 executions?
Because 0.3 sec for this stuff is awfully slow.

 

[Azlier]

1000 executions, with the results multiplied by 100.

 

[Troll-Brain]

Try to change the order of the benchmark (Player() first and then your array).
You can have the opposite result.

Also you really should use a higher value, like 10000 and a TriggerSleepAction(0) (to open a new tread) between the 2 evaluations, to be much more accurate.

PS :

I'm sure you know it, but don't forget to disable the debug mode when you save the script, or your function won't be inlined.

 

[Azlier]

I made sure that Ren disabled debug mode.

New benchmark script (can 10000 operations survive the op limit?).