[Simple] Converting GUI to JASS

[xoxdragonxox]

Solved


Here is my GUI trigger im trying to convert it to jass.

• ItemS
  • Events
    • Time - Every 90.00 seconds of game time
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 19, do (Actions)
      • Loop - Actions
        • Set Points[3] = (Random point in MAP <gen>)
        • Item - Create Items[(Random integer number between 1 and 9)] at Points[3]
        • Custom script: call RemoveLocation(udg_Points[3])

Here is my attempt

function Trig_ItemS_Actions takes nothing returns nothing
    local integer i = 0
    loop
        exitwhen i > 19
        set udg_Points[3] = GetRandomLocInRect(gg_rct_MAP)
        call CreateItemLoc( udg_Items[GetRandomInt(1, 9)], udg_Points[3] )
        call RemoveLocation(udg_Points[3])
        set i = i + 1
    endloop
endfunction

//===========================================================================
function InitTrig_ItemS takes nothing returns nothing
    set gg_trg_ItemS = CreateTrigger(  )
    call TriggerRegisterTimerEventPeriodic( gg_trg_ItemS, 90.00 )
    call TriggerAddAction( gg_trg_ItemS, function Trig_ItemS_Actions )
endfunction

My question is can it be done a better way then what i have above.

and here is my 2nd gui

• MuzzleFlash
  • Events
    • Unit - A unit owned by Neutral Victim Is attacked
    • Unit - A unit owned by Neutral Extra Is attacked
  • Conditions
    • ((Attacking unit) is A Hero) Equal to True
    • Reloading[(Player number of (Owner of (Attacking unit)))] Equal to 0
  • Actions
    • Special Effect - Create a special effect attached to the weapon of (Attacking unit) using war3mapImported\Konstrukt_ShotgunEffektAttachment.MDX
    • Set MuzzleFlash[(Player number of (Owner of (Attacking unit)))] = (Last created special effect)
    • Wait 1.00 seconds
    • Special Effect - Destroy MuzzleFlash[(Player number of (Owner of (Attacking unit)))]

i have no clue how to convert that lol help.... the reason why i wan tthem in jass is because, of cource better performance and no leaks =]

 

[Dinowc]

something like this:

function Items_actions takes nothing returns nothing
    local integer i = 0
    loop     
        call CreateItem(udg_Items[GetRandomInt(1, 9)], GetRandomReal(udg_MinX, udg_MaxX), GetRandomReal(udg_MinY, udg_MaxY))
        set i = i + 1
        exitwhen i > 19
    endloop
endfunction

//===========================================================================
function InitTrig_Items takes nothing returns nothing
    local timer t = CreateTimer()
    call TimerStart(t, 90., true, function Items_actions)
    set t = null

    set udg_MaxX = GetRectMaxX(gg_rct_MAP)
    set udg_MinX = GetRectMinX(gg_rct_MAP)
    set udg_MaxY = GetRectMaxY(gg_rct_MAP)
    set udg_MinY = GetRectMinY(gg_rct_MAP)
endfunction

btw can you use vJass?

if yes, use Sevion's example (sry bud for taking your idea with timer xd)

 

[Sevion]

The first can be optimized. Instead of a trigger, use a timer:

(Assuming you have NewGen)

scope PeriodicItemCreate initializer Init
globals // Why globals? They never change unless you move the rect. Which... you never do, do you? If you do, just reset them <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink    ;)" loading="lazy" data-shortname=";)" />
    private real maxX = GetRectMaxX(gg_rct_MAP)
    private real minX = GetRectMinX(gg_rct_MAP)
    private real maxY = GetRectMaxY(gg_rct_MAP)
    private real minY = GetRectMinY(gg_rct_MAP)
endglobals

private function Actions takes nothing returns nothing
    local integer i = 19
    loop
        exitwhen i == 0 // Why like this? &gt; is more operation heavy than ==
        call CreateItem( udg_Items[GetRandomInt(1, 9)], GetRandomReal( minX, maxX ), GetRandomReal( minY, maxY )) // Inline the GetRandom&#039;s
        set i = i - 1
    endloop
endfunction

//===========================================================================
private function Init takes nothing returns nothing
    call TimerStart( CreateTimer(), 90.00, true, function Actions ) // Timer more efficient than Trigger in this case
endfunction
endscope

And the second:

scope MuzzleFlash initializer Init // Scope == Encapsulation
    globals
        private constant string MODEL = "war3mapImported\\Konstrukt_ShotgunEffektAttachment.MDX" // Model Path
        private constant string ATTACH = "weapon" // Attachment Point
        private constant real WAIT_TIME = 1.00 // Wait Time
    endglobals
    
    private function Actions takes nothing returns nothing
        local effect e = AddSpecialEffectTarget(MODEL, GetTriggerUnit(), ATTACH)
        call TriggerSleepAction(WAIT_TIME) // For this, TSA is fine, accuracy isn't exactly needed
        call DestroyEffect(e) // Flush leaks
        set e = null
    endfunction
    
    private function Init takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ATTACKED) // BJ will be fine for this, if you seriously want efficiency, just convert to native version
        call TriggerAddAction(t, function Actions)
    endfunction
endscope

 

[xoxdragonxox]

Ugh. I dont have NewGen lol =[ i dont like using those tools lol. is there a way to optmize it without newgen, and if anyone can kindly help me with the 2nd gui I'd greatly appreciate it

Thanks with the help so far guys !

 

[Dinowc]

I dont have NewGen lol =[ i dont like using those tools

your kidding right? everybody loves NewGen

all you have to do is download it and run it

anyway, try using my code then

 

[xoxdragonxox]

None are working without newgen. and i just tried to download newgen and its just giving me allot of problems, lots of dll's missing and corrupted files, invalid start up files missing and crap lol i tried to use it before, same problem i think its my pc iunno.

and like i said none of the triggers u have have will work without newgen:banghead:

 

[jig7c]

>sevion
in the second trigger, you don't have the conditions set..

also

can't you make, and also will the function below run every 90 seconds?

 call TimerStart( CreateTimer(), 90.00, true, function Actions )

to

 call DestroyTimer (TimerStart( CreateTimer(), 90.00, true, function Actions ))

 

[Sevion]

Whoops, I forgot the conditions

Here's them without vJASS implementations:

// Put globals into the map header
globals // Why globals? They never change unless you move the rect. Which... you never do, do you? If you do, just reset them <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink    ;)" loading="lazy" data-shortname=";)" />
    real maxX = GetRectMaxX(gg_rct_MAP)
    real minX = GetRectMinX(gg_rct_MAP)
    real maxY = GetRectMaxY(gg_rct_MAP)
    real minY = GetRectMinY(gg_rct_MAP)
endglobals

function Actions takes nothing returns nothing
    local integer i = 19
    loop
        exitwhen i == 0 // Why like this? &gt; is more operation heavy than ==
        call CreateItem( udg_Items[GetRandomInt(1, 9)], GetRandomReal( minX, maxX ), GetRandomReal( minY, maxY )) // Inline the GetRandom&#039;s
        set i = i - 1
    endloop
endfunction

//===========================================================================
function InitTrig_Items takes nothing returns nothing
    call TimerStart( CreateTimer(), 90.00, true, function Actions ) // Timer more efficient than Trigger in this case
endfunction

// Put globals into Map Header
    globals
        constant string MODEL = "war3mapImported\\Konstrukt_ShotgunEffektAttachment.MDX" // Model Path
        constant string ATTACH = "weapon" // Attachment Point
        constant real WAIT_TIME = 1.00 // Wait Time
    endglobals
    
     function Actions takes nothing returns nothing
        local effect e = AddSpecialEffectTarget(MODEL, GetTriggerUnit(), ATTACH)
        call TriggerSleepAction(WAIT_TIME) // For this, TSA is fine, accuracy isn't exactly needed
        call DestroyEffect(e) // Flush leaks
        set e = null
    endfunction

    function Conditions takes nothing returns boolean
        return GetUnitTypeId(GetFilterUnit(), UNIT_TYPE_HERO) and udg_Reload[GetPlayerId(GetOwningPlayer(GetFilterUnit()))] == 0
    endfunction
    
    function InitTrig_MuzzleFlash takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ATTACKED) // BJ will be fine for this, if you seriously want efficiency, just convert to native version
        call TriggerAddCondition(t, Filter(function Conditions))
        call TriggerAddAction(t, function Actions)
    endfunction

By the way, jig7c, does the timer continue to run if you destroy without pausing? I believe it does, but am not sure

You could also inline the conditions and actions... but... I'm being lazy

 

[xoxdragonxox]

Thank you Dinowc, Sevion, jig7c, for your help and input I really do appreciate it! +rep

 

[Laiev]

>> By the way, jig7c, does the timer continue to run if you destroy without pausing? I believe it does, but am not sure

The timer stop but can bug some times (don't know what post i read it), so the most recommended thing is pause and then destroy it.

 

[xoxdragonxox]

Oh sorry one more thing, cant i just combine those 2 globals into one or do they need to be seperate globals?

 

[Flare]

call DestroyTimer (TimerStart( CreateTimer(), 90.00, true, function Actions ))

That wouldn't work

native TimerStart           takes timer whichTimer, real timeout, boolean periodic, code handlerFunc returns nothing

TimerStart doesn't return any timer, so you would essentially be doing

call DestroyTimer (nothing) //if you could call &#039;nothing&#039; a valid type <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue    :p" loading="lazy" data-shortname=":p" />

The timer stop but can bug some times (don't know what post i read it), so the most recommended thing is pause and then destroy it.

From what I recall from Rising_Dusk's timer tutorial (although, it's been some time since I've had a read of it ), a timer will continue to count down if destroyed while running OR, if it's repeating, it will do another countdown if destroyed within its callback function - not 100% certain on this, and laziness gets the better of me when it comes to finding these threads

Oh sorry one more thing, cant i just combine those 2 globals into one or do they need to be seperate globals?

You haven't actually identified which globals you are talking about, but I would imagine it's extremely unlikely.

 

[xoxdragonxox]

Uhmm. I just tried to put the 2 triggers into my map and i did put the globals in and im getting 1522 Compile Errors. when i remove the triggers it compiles properly :thdown:

 

[Sevion]

It should be like this in the map header (if you don't have NewGen):

globals
    constant string MODEL = "war3mapImported\\Konstrukt_ShotgunEffektAttachment.MDX" // Model Path
    constant string ATTACH = "weapon" // Attachment Point
    constant real WAIT_TIME = 1.00 // Wait Time
    real maxX = GetRectMaxX(gg_rct_MAP)
    real minX = GetRectMinX(gg_rct_MAP)
    real maxY = GetRectMaxY(gg_rct_MAP)
    real minY = GetRectMinY(gg_rct_MAP)
endglobals

 

[Flare]

It should be like this in the map header (if you don't have NewGen):

Free global declaration only exists through NewGen (check the manual). The variables would have to be created through the Variable Editor window without NewGen

 

[Sevion]

IIRC you can declare one, and only one globals block in the map header.

 

[xoxdragonxox]

Im a lost case right now :thdown:

So it wont work? lol if not thats totaly fine you guys have tried to help me :thup:

 

[Sevion]

It should work fine... Try it.

 

[xoxdragonxox]

Ugh. Still not working . Im pretty sure im putting it all in properly. i get 9 errors and the 9 are the trigger i put in the map header

I put this in the map header

globals
    constant string MODEL = "war3mapImported\\Konstrukt_ShotgunEffektAttachment.MDX" // Model Path
    constant string ATTACH = "weapon" // Attachment Point
    constant real WAIT_TIME = 1.00 // Wait Time
    real maxX = GetRectMaxX(gg_rct_MAP)
    real minX = GetRectMinX(gg_rct_MAP)
    real maxY = GetRectMaxY(gg_rct_MAP)
    real minY = GetRectMinY(gg_rct_MAP)
endglobals

and these as my 2 triggeres

function Actions takes nothing returns nothing
    local integer i = 19
    loop
        exitwhen i == 0 // Why like this? > is more operation heavy than ==
        call CreateItem( udg_Items[GetRandomInt(1, 9)], GetRandomReal( minX, maxX ), GetRandomReal( minY, maxY )) // Inline the GetRandom's
        set i = i - 1
    endloop
endfunction

//===========================================================================
function InitTrig_Items takes nothing returns nothing
    call TimerStart( CreateTimer(), 90.00, true, function Actions ) // Timer more efficient than Trigger in this case
endfunction

and

     function Actions takes nothing returns nothing
        local effect e = AddSpecialEffectTarget(MODEL, GetTriggerUnit(), ATTACH)
        call TriggerSleepAction(WAIT_TIME) // For this, TSA is fine, accuracy isn't exactly needed
        call DestroyEffect(e) // Flush leaks
        set e = null
    endfunction

    function Conditions takes nothing returns boolean
        return GetUnitTypeId(GetFilterUnit(), UNIT_TYPE_HERO) and udg_Reload[GetPlayerId(GetOwningPlayer(GetFilterUnit()))] == 0
    endfunction
    
    function InitTrig_MuzzleFlash takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ATTACKED) // BJ will be fine for this, if you seriously want efficiency, just convert to native version
        call TriggerAddCondition(t, Filter(function Conditions))
        call TriggerAddAction(t, function Actions)
    endfunction

 

[Sevion]

What are the 9 errors?