Snippet Bounds

[Viikuna]

Actually, bound sentinel does the job. You just gotta modify it a bit for your map, so it can for example, call destroy methods for your projectiles and stuff like that.

 

[SerraAvenger]

public constant rect WORLD  = GetWorldBounds()
//! runtextmacro BOUNDS_BUFFER()
public constant real MAX_X  = GetRectMaxX(WORLD) - BUFFER
public constant real MIN_X  = GetRectMinX(WORLD) + BUFFER
public constant real MAX_Y  = GetRectMaxY(WORLD) - BUFFER
public constant real MIN_Y  = GetRectMinY(WORLD) + BUFFER

WRONG. Unconstantize those, or the optimizer will inline them and you get mass leaks and lose efficiency.

Hmmm, that's wrong.
You can have

constant trigger MyTrigger = CreateTrigger()

and it will not create a trigger every time you use MyTrigger, not even in an optimized map (I used to use it in most of my maps, after all).

 

[T.s.e]

I think what he means is that every time you use MyTrigger..

call TriggerRegisterTimerEvent(MyTrigger, ...) // For instance..

It would become this:

call TriggerRegisterTimerEvent(CreateTrigger(), ...)

As using a constant integer would be inlined to its value.

Edit:
Apparently, it does not create a new trigger every time it runs.

 

[GetTriggerUnit-]

Why don't you use the native IsPointInRegion(whichregion, x, y)

I think it would be faster that way.

 

[Sevion]

Why don't you use the native IsPointInRegion(whichregion, x, y)

I think it would be faster that way.

Zomg. ;o

Anywho, now that we know constant triggers don't create new instances every use, do reals and rects?

 

[GetTriggerUnit-]

Guess not if you use a global region?

set Region = CreateRegion()
call RegionAddRect(Region, bj_mapInitialPlayableArea)


// Then after....

if IsPointInRegion(Region, whichX, whichY) then
endif

 

[Sevion]

The only problem is that I can't get regions' maximum and minimum coordinates

I'd still have to use a rect for that.

Actually, second, I wonder,

I could actually do:

IsPointInRegion(WorldRegion, x, 0.)
IsPointInRegion(WorldRegion, 0., y)

For checking X and Y o_o'

Though, it COULD potentially bug if you checked x and y separately.

:-/

That's the only way I can think of making it inline friendly >_<

 

[GetTriggerUnit-]

Why do you need to have them separeted?

function AreCoordSafe takes real x, real y returns boolean
    return IsPointInRegion(Region, x, y)
endfunction

function SetUnitCoordSafe takes unit u, real x, real y returns nothing
    if AreCoordSafe(x,y) then
        call SetUnitX(u,x)
        call SetUnitY(u,y)
    else
        call DoNothingBJ
    endif
endfunction

 

[Sevion]

It's just some people like them separated :-/

Anyways, I'm going to update it with them merged, I guess.

 

[GetTriggerUnit-]

k, my bad.¸

EDIT: for new code,

public region WorldReg = CreateRegion()

Automatic critical error, try it on your own if you do not trust me.
Instead, create the region in the Init function or w/e.

 

[Sevion]

Damn, I'm critting whether or not I'm creating it in my Init function. Sec, let me find the error ;o

Snap, it seems I can't make the globals constant as creating rects or regions there crits.

 

[GetTriggerUnit-]

Why are these public variables?
You'd rather make them private, no?

 

[uberfoop]

Why are these public variables?
You'd rather make them private, no?

Public makes them fairly safe from conflict, and there's no real reason that map bound variables shouldn't be used directly, especially since there aren't wrappers to return them.

 

[Jesus4Lyf]

I'm currently intending to graveyard this soon.
...
The right way to do this is put BoundSentinel into your map. Should rip it off and make it use world bounds or something instead.

Checking the safety before moving the unit is just the wrong way to do it.

No objections, graveyarded.