Snippet String2PlayerColoredString

[Komaqtion]

Ok, what is it that this needs to be approved, or at least thoroughly reviewed ? :S

(BumP ! )

 

[Komaqtion]

PLEASE !!!!

Review it, because I *need it for my current system !

* I could do it without the library, but it reduces the length of the code quite a bit !

 

[Komaqtion]

Bump it up !

C'mon people, am I being ignored somehow ?!
(I can't seem to get any attention on my posts lately )

 

[TriggerHappy]

Ten pages for a coloring script

 

[Komaqtion]

Yeah, I know !!!

That's why I think t's enough now, and this would be more than enough to get a good and thorough review, and also get approved... Right ?!

 

[GetTriggerUnit-]

Why not use a struct? I'd rather see something like that, imo.

library Colors initializer onInit

    struct Color
        integer Redstring
        integer Bluestring
        integer Greenstring
        string PlayerC
        string word
        method PlayerString takes Color int, string txt returns string
            local Color good = int - 1
            return good.PlayerC + txt + "|r"
        endmethod
        
        private static method onInit takes nothing returns nothing
            local Color d = Color.create()
            set d.PlayerC = "|c00ff0202"
            set d.Redstring = 0xff
            set d.Bluestring = 0x02
            set d.Greenstring = 0x02
            set d.word = "red"
            
            set d = Color.create()
            set d.PlayerC = "|c000041ff"
            set d.Redstring = 0x00
            set d.Bluestring = 0x41
            set d.Greenstring = 0xff
            set d.word = "blue"
            
            set d = Color.create()
            /* etc... */
        endmethod
    endstruct
        
        private function Color_onChange takes player p, playercolor c returns nothing
            local Color pId = GetPlayerId(p)
            local Color cId = GetHandleId(c)
            
            set pId.Redstring = cId.Redstring
            set pId.Bluestring = cId.Bluestring
            set pId.Greenstring = cId.Greenstring
            set pId.PlayerC = cId.PlayerC
            set pId.word = cId.word
        endfunction
        
        hook SetPlayerColor Color_onChange
    
    // call functions
    /*
    
    local string s = Color.PlayerString(0, "<3 Komaqtion")
    
    */

endlibrary

 

[Komaqtion]

I'm actually becoming pretty irritated about these two submissions I've got here !
I've recieved a lot of help, and both of these have gotten updated [a lot] !!!
I just don't see why it can't be approved ?!

I mean this on in particular has recieved 145 replies !!! (Now 146 )
And it still isn't good enough ?!?!
That's just wrong

(And, sorry GetTriggerUnit, but I'm not gonna redo the whole thing just like that... Sorry )

 

[Jesus4Lyf]

call SetTextTagColor( tag, Red[GetPlayerId( p )], Green[GetPlayerId( p )], Blue[GetPlayerId( p )], alpha )

Repeating GetPlayerId( p )... better to store it.

function PlayerColoredTextTag takes integer alpha, player p, texttag tag returns nothing

Hmm. It's kind of up to you, but I don't find the order of these parameters intuitive. I'd actually have them in the exact opposite order. Most important thing first (subject - texttag), then the next most important thing (player) then the thing that is there because you needed to put it there, alpha. It would also match better with Blizzard's convention. Same for the other text tag one.

    function GetPlayerByColor takes string s returns player
        local integer i = 0
        
        set s = StringCase( s, false )
        set s = CompressString( s )
        
        loop 
        
            if s == PlayerColorWordString<i> then
                return Player( i )
            endif
            
            set i = i + 1
            
        exitwhen ( i &gt;= 13 )
        endloop
        
        if s == PlayerColorWordString[13] then
            return Player( 8 )
        elseif s == PlayerColorWordString[14] or s == PlayerColorWordString[15] then
            return Player( 2 )
        elseif s == PlayerColorWordString[16] or s == PlayerColorWordString[17] then
            return Player(12)
        endif
        
        return null
    endfunction</i>

Should inline (use stringhash, some math perhaps and an array read).

if SubString( compstring, i, i + 1 ) != " " or SubString( compstring, i, i + 1 ) != "." or SubString( compstring, i, i + 1 ) != "," then

Your CompressString function is not useful. That clause will always return true, because it will always pass at least one of those [LJASS]!=[/LJASS] checks and you have used [LJASS]or[/LJASS]. I don't think you need this anyway.

function PlayerColoredString takes integer playerId, string s returns string

Doesn't follow your own convention, it's not intuitive - it should have ById on the end to match your other functions, and there should be a PlayerColoredString which takes a player.

function GetPlayerColorByColor takes string s returns string

Wut?

Thanks for your patience.

 

[Komaqtion]

call SetTextTagColor( tag, Red[GetPlayerId( p )], Green[GetPlayerId( p )], Blue[GetPlayerId( p )], alpha )

Repeating GetPlayerId( p )... better to store it.

Yeah, will do

function PlayerColoredTextTag takes integer alpha, player p, texttag tag returns nothing

Hmm. It's kind of up to you, but I don't find the order of these parameters intuitive. I'd actually have them in the exact opposite order. Most important thing first (subject - texttag), then the next most important thing (player) then the thing that is there because you needed to put it there, alpha. It would also match better with Blizzard's convention. Same for the other text tag one.

Hehe, yeah I just noticed that now XD
Will change

    function GetPlayerByColor takes string s returns player
        local integer i = 0
        
        set s = StringCase( s, false )
        set s = CompressString( s )
        
        loop 
        
            if s == PlayerColorWordString<i> then
                return Player( i )
            endif
            
            set i = i + 1
            
        exitwhen ( i &gt;= 13 )
        endloop
        
        if s == PlayerColorWordString[13] then
            return Player( 8 )
        elseif s == PlayerColorWordString[14] or s == PlayerColorWordString[15] then
            return Player( 2 )
        elseif s == PlayerColorWordString[16] or s == PlayerColorWordString[17] then
            return Player(12)
        endif
        
        return null
    endfunction</i>

Should inline (use stringhash, some math perhaps and an array read).

Hmm... I'm sorry but I don't really get what you mean :S
How could all that possibly inline ? XD

if SubString( compstring, i, i + 1 ) != " " or SubString( compstring, i, i + 1 ) != "." or SubString( compstring, i, i + 1 ) != "," then

Your CompressString function is not useful. That clause will always return true, because it will always pass at least one of those [LJASS]!=[/LJASS] checks and you have used [LJASS]or[/LJASS]. I don't think you need this anyway.

Oh, so I should just remove it ?
But what if I write something like "Bl Ue", isn't it useful to be able to interpret that ?

function PlayerColoredString takes integer playerId, string s returns string

Doesn't follow your own convention, it's not intuitive - it should have ById on the end to match your other functions, and there should be a PlayerColoredString which takes a player.

Yeah, ok will add

function GetPlayerColorByColor takes string s returns string

Wut?

What ?!
What's wrong with that one ?
If I just need a color, I'd use that...

Thanks for your patience.

Hehe XD Thanks for yours !
I'll work on the changes now !

 

[Jesus4Lyf]

Hmm... I'm sorry but I don't really get what you mean :S
How could all that possibly inline ? XD

return MyArray[StringHash(s)/100+200/*or something to make a valid index*/]

Oh, so I should just remove it ?
But what if I write something like "Bl Ue", isn't it useful to be able to interpret that ?

I'd say yes. At the moment it doesn't work, so it seems no one cares anyway.

What ?!
What's wrong with that one ?
If I just need a color, I'd use that...

You misunderstand - I have no idea what that function does.

 

[Komaqtion]

return MyArray[StringHash(s)/100+200/*or something to make a valid index*/]

I'm sorry, but I don't know what [ljass]StringHash[/ljass] is :S
Please, could you give me a better example...
And, what variable type should MyArray be ?

I'd say yes. At the moment it doesn't work, so it seems no one cares anyway.

Well, why not just fix it to make it work then ?!

You misunderstand - I have no idea what that function does.

That function simply gives you the color code of the color you type...

Like if you type [ljass]call GetPlayerColorByColor( "blue" )[/ljass] then it'd return "|c001be5b8" hopefully XD

 

[Jesus4Lyf]

I'm sorry, but I don't know what [ljass]StringHash[/ljass] is :S
Please, could you give me a better example...
And, what variable type should MyArray be ?

Look closely:

scope X initializer OnInit
    globals
        private integer array Red
        private integer array Green
        private integer array Blue
        private integer array RedString
        private integer array GreenString
        private integer array BlueString
        private string array PlayerColor
        private string array PlayerColorString
        private string array PlayerColorWord
        private string array PlayerColorWordString
    endglobals
    
    private function OnInit takes nothing returns nothing
        local integer i
        
        set PlayerColorString[0] = "|c00ff0202"
        set RedString[0] = 0xff
        set GreenString[0] = 0x02
        set BlueString[0] = 0x02
        set PlayerColorWordString[0] = "red"
        set PlayerColorString[1] = "|c000041ff"
        set RedString[1] = 0x00
        set GreenString[1] = 0x41
        set BlueString[1] = 0xff
        set PlayerColorWordString[1] = "blue"
        set PlayerColorString[2] = "|c001be5b8"
        set RedString[2] = 0x1b
        set GreenString[2] = 0xe5
        set BlueString[2] = 0xb8
        set PlayerColorWordString[2] = "teal"
        set PlayerColorString[3] = "|c00530080"
        set RedString[3] = 0x53
        set GreenString[3] = 0x00
        set BlueString[3] = 0x80
        set PlayerColorWordString[3] = "purple"
        set PlayerColorString[4] = "|c00fffc00"
        set RedString[4] = 0xff
        set GreenString[4] = 0xfc
        set BlueString[4] = 0x00
        set PlayerColorWordString[4] = "yellow"
        set PlayerColorString[5] = "|c00fe890d"
        set RedString[5] = 0xfe
        set GreenString[5] = 0x89
        set BlueString[5] = 0x0d
        set PlayerColorWordString[5] = "orange"
        set PlayerColorString[6] = "|c001fbf00"
        set RedString[6] = 0x1f
        set GreenString[6] = 0xbf
        set BlueString[6] = 0x00
        set PlayerColorWordString[6] = "green"
        set PlayerColorString[7] = "|c00e45aaf"
        set RedString[7] = 0xe4
        set GreenString[7] = 0x5a
        set BlueString[7] = 0xaf
        set PlayerColorWordString[7] = "pink"
        set PlayerColorString[8] = "|c00949596"
        set RedString[8] = 0x94
        set GreenString[8] = 0x95
        set BlueString[8] = 0x96
        set PlayerColorWordString[8] = "grey"
        set PlayerColorString[9] = "|c007dbef1"
        set RedString[9] = 0x7d
        set GreenString[9] = 0xbe
        set BlueString[9] = 0xf1
        set PlayerColorWordString[9] = "lightblue"
        set PlayerColorString[10] = "|c000f6145"
        set RedString[10] = 0x0f
        set GreenString[10] = 0x61
        set BlueString[10] = 0x45
        set PlayerColorWordString[10] = "darkgreen"
        set PlayerColorString[11] = "|c004d2903"
        set RedString[11] = 0x4d
        set GreenString[11] = 0x29
        set BlueString[11] = 0x03
        set PlayerColorWordString[11] = "brown"

        set PlayerColorString[12] = "|c00272727"
        set RedString[12] = 0x27
        set GreenString[12] = 0x27
        set BlueString[12] = 0x27
        set PlayerColorWordString[12] = "darkgrey"
        
        set i=13
        loop
            set i=i-1
            call BJDebugMsg(I2S( StringHash(PlayerColorWordString<i>)/29000000+73 ))
            exitwhen i==0
        endloop
    endfunction
endscope
</i>

Copy/paste and see what it displays. StringHash converts a string into an integer. You can, with some math, use the result in an array index, to make said function inline.

Well, why not just fix it to make it work then ?!

Because (my opinion) it's useless and a large performance hit which leaks strings.

That function simply gives you the color code of the color you type...

Document it. It should inline too, using the above method.

You've done nasty things to perfect functions to block them from inlining for unknown reasons. Please revert those changes.

Example:

    function GetPlayerColorString takes player p returns string
        local integer id = GetPlayerId( p )
        
        return PlayerColor[id]
    endfunction

It was perfect before.

    function GetPlayerColorString takes player p returns string
        return PlayerColor[GetPlayerId( p )]
    endfunction

I think it's time for you to read this.

 

[TriggerHappy]

@J4L

I'm fairly sure string hash will be impossible to fit into an array.
Because AFAIK the value range so far.

 

[Komaqtion]

Ok, I've done this now:

library PlayerColors initializer Init


///////////////////////////////////////////////////////////////////////////////////////////////////////
//***************************************************************************************************//
//@@/////////////////////////////////// *//PlayerColorUtils\\* ////////////////////////////////////@@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%                 @@//
//@@                 %%                                                         %%                 @@//
//@@                 %%    //\\\\\               /////////  ///          \\\    %%                 @@//
//@@                 %%    //\\   \\\        //////         ///          \\\    %%                 @@//
//@@                 %%    //\\     \\\     /////           ///          \\\    %%                 @@//
//@@                 %%    //\\     ///   ////              ///          \\\    %%                 @@//
//@@                 %%    //\\   ///    ////               ///          \\\    %%                 @@//
//@@                 %%    //\\///      ////                ///          \\\    %%                 @@//
//@@                 %%    //\\         \\\\                ////        \\\\    %%                 @@//
//@@                 %%    //\\          \\\\               ////        \\\\    %%                 @@//
//@@                 %%    //\\           \\\\              ////        \\\\    %%                 @@//
//@@                 %%    //\\             \\\\\            ////      \\\\     %%                 @@//
//@@                 %%    //\\               \\\\\\          ////    \\\\      %%                 @@//
//@@                 %%    //\\                  \\\\\\\\\       ///\\\         %%                 @@//
//@@                 %%                                                         %%                 @@//
//@@                 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%                 @@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                                   Made by , Komaqtion                                         @@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                                        Purpose:                                               @@//
//@@                                                                                               @@//
//@@             ¤ This snippet is supposed to help people to, with ease, to use playercolors      @@//
//@@               in all aspects they'd possibly want.                                            @@//
//@@                                                                                               @@//
//@@                                         Usage:                                                @@//
//@@                                                                                               @@//
//@@             ¤ To use this snippet, simply type "call PlayerColoredString(playerid, string)"   @@//
//@@               where "string" is the string you want to colorize, and "playerid"               @@//
//@@               is the player number of the player, whose color you wan to use.                 @@//
//@@               Note: This uses JASS' player number range, meaning that                         @@//
//@@               Player 1(Red)'s number is 0, and Player 2(Blue)'s number is 1,                  @@//
//@@               and so on...                                                                    @@//
//@@               You can also get only the players color-string for own usage...                 @@//
//@@               This is accomplished by using the function "GetPlayerColorString"               @@//
//@@               which takes the player to get the string, or you can also use                   @@//
//@@               the GetPlayerColorStringById function, which takes the player's                 @@//
//@@               Id, or number instead <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin    :D" loading="lazy" data-shortname=":D" />                                                        @@//
//@@               You can also change the color of texttags using this snippet...                 @@//
//@@               The function is called &quot;PlayerColoredTextTag&quot; and takes integer alpha           @@//
//@@               which is transparency, player p, the playercolor you which to use, and          @@//
//@@               texttag tag which is the texttag you which to change the color of !             @@//
//@@               You can also use the function &quot;GetPlayerByColor&quot; which takes a string (color)   @@//
//@@               and returns the player which has that specific color. You can even type         @@//
//@@               &quot;ReD&quot; or &quot;REd&quot; or even &quot;..,,  R, e.., d&quot; and it&#039;ll return Player(0) or          @@//
//@@               player red in all three cases. And, you can also get the player&#039;s color         @@//
//@@               this way.                                                                       @@//
//@@                                                                                               @@//
//@@               WARNING: If you put an invalid player as an argument, in any of the functions,  @@//
//@@               it WILL return Player( 0 ), or Player &quot;Red&quot; !                                   @@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                                    Requirements:                                              @@//
//@@                                                                                               @@//
//@@             ¤ This snippet&#039;s only requirement is vJASS compilement, which is                  @@//
//@@               easiest achieved by downloading JASS Newgen Pack, at                            @@//
//@@               <a href="http://www.thehelper.net/forums/showthread.php?t=73936" class="link link--internal">http://www.thehelper.net/forums/showthread.php?t=73936</a>                          @@//
//@@               You&#039;ll also have to update JASS Helper to the latest version...                 @@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                                        Credits:                                               @@//
//@@                                                                                               @@//
//@@             ¤ Azlier, for helping me out alot with several bugfixes and tweaking !            @@//
//@@               Jesus4Lyf, for also helping me out alot ! <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin    :D" loading="lazy" data-shortname=":D" />                                    @@//
//@@               Quraji, for helping me add the &quot;GetPlayerByColor&quot; function ! <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin    :D" loading="lazy" data-shortname=":D" />                 @@//
//@@                                                                                               @@//
//@@               And credits, if you use this that is, is not needed to give me                  @@//
//@@               though it&#039;s always welcome <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink    ;)" loading="lazy" data-shortname=";)" />                                                   @@//
//@@                                                                                               @@//
//@@///////////////////////////////////////////////////////////////////////////////////////////////@@//
//***************************************************************************************************//
///////////////////////////////////////////////////////////////////////////////////////////////////////


    globals
        private integer array Red
        private integer array Green
        private integer array Blue
        private integer array RedString
        private integer array GreenString
        private integer array BlueString
        private string array PlayerColor
        private string array PlayerColorString
        private string array PlayerColorWord
        private string array PlayerColorWordString
        
        private hashtable StoredColors = InitHashtable()
        
        private constant string EndString = &quot;|r&quot;
    endglobals
    
    function PlayerColoredStringById takes integer playerId, string s returns string
        return PlayerColor[playerId] + s + EndString
    endfunction
    
    function PlayerColoredString takes player p, string s returns string
        return PlayerColor[GetPlayerId( p )] + s + EndString
    endfunction
    
    function PlayerColoredTextTag takes texttag tag, player p, integer alpha returns nothing
        local integer id = GetPlayerId( p )
        
        if p != null then
            call SetTextTagColor( tag, Red[id], Green[id], Blue[id], alpha )
        endif

    endfunction
    
    function PlayerColoredTextTagById takes texttag tag, integer playerId, integer alpha returns nothing
        call SetTextTagColor( tag, Red[playerId], Green[playerId], Blue[playerId], alpha )
    endfunction
    
    function GetPlayerColorString takes player p returns string
        return PlayerColor[GetPlayerId( p )]
    endfunction
    
    function GetPlayerColorStringById takes integer playerId returns string
        return PlayerColor[playerId]
    endfunction
    
    /*private function CompressString takes string compstring returns string
        local integer w = StringLength( compstring )
        local integer i = 0
        local string s = &quot;&quot;
        
        loop
        
                if SubString( compstring, i, i + 1 ) != &quot; &quot; or SubString( compstring, i, i + 1 ) != &quot;.&quot; or SubString( compstring, i, i + 1 ) != &quot;,&quot; then
                    set s = s + SubString( compstring, i, i + 1 )
                endif
                
            set i = i + 1
            
        exitwhen i &gt; w
        endloop
        
        return s
    endfunction*/
    
    function GetPlayerByColor takes string s returns player
        return LoadPlayerHandle( StoredColors, 1, StringHash( StringCase( s, false ) ) / 20000000 + 96 )
    endfunction
    
    function GetPlayerColorStringByColor takes string s returns string
        return PlayerColor[ GetPlayerId( LoadPlayerHandle( StoredColors, 1, StringHash( StringCase( s, false ) ) / 20000000 + 96 ) ) ]
    endfunction
    
    private function OnColorChange takes player whichPlayer, playercolor color returns nothing
        local integer id = GetPlayerId( whichPlayer )
        local integer pc = GetHandleId( color )

        set PlayerColor[id] = PlayerColorString[pc]
        set Red[id] = RedString[pc]
        set Green[id] = GreenString[pc]
        set Blue[id] = BlueString[pc]
        set PlayerColorWord[id] = PlayerColorWordString[pc]
        
        call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorString[ pc ] ) / 20000000 + 96, whichPlayer )
    endfunction
    
    hook SetPlayerColor OnColorChange
    
    private function Init takes nothing returns nothing
        local integer i = 12
        local integer i2
    
        set PlayerColorString[0] = &quot;|c00ff0202&quot;
        set RedString[0] = 0xff
        set GreenString[0] = 0x02
        set BlueString[0] = 0x02
        set PlayerColorWordString[0] = &quot;red&quot;
        set PlayerColorString[1] = &quot;|c000041ff&quot;
        set RedString[1] = 0x00
        set GreenString[1] = 0x41
        set BlueString[1] = 0xff
        set PlayerColorWordString[1] = &quot;blue&quot;
        set PlayerColorString[2] = &quot;|c001be5b8&quot;
        set RedString[2] = 0x1b
        set GreenString[2] = 0xe5
        set BlueString[2] = 0xb8
        set PlayerColorWordString[2] = &quot;teal&quot;
        set PlayerColorString[3] = &quot;|c00530080&quot;
        set RedString[3] = 0x53
        set GreenString[3] = 0x00
        set BlueString[3] = 0x80
        set PlayerColorWordString[3] = &quot;purple&quot;
        set PlayerColorString[4] = &quot;|c00fffc00&quot;
        set RedString[4] = 0xff
        set GreenString[4] = 0xfc
        set BlueString[4] = 0x00
        set PlayerColorWordString[4] = &quot;yellow&quot;
        set PlayerColorString[5] = &quot;|c00fe890d&quot;
        set RedString[5] = 0xfe
        set GreenString[5] = 0x89
        set BlueString[5] = 0x0d
        set PlayerColorWordString[5] = &quot;orange&quot;
        set PlayerColorString[6] = &quot;|c001fbf00&quot;
        set RedString[6] = 0x1f
        set GreenString[6] = 0xbf
        set BlueString[6] = 0x00
        set PlayerColorWordString[6] = &quot;green&quot;
        set PlayerColorString[7] = &quot;|c00e45aaf&quot;
        set RedString[7] = 0xe4
        set GreenString[7] = 0x5a
        set BlueString[7] = 0xaf
        set PlayerColorWordString[7] = &quot;pink&quot;
        set PlayerColorString[8] = &quot;|c00949596&quot;
        set RedString[8] = 0x94
        set GreenString[8] = 0x95
        set BlueString[8] = 0x96
        set PlayerColorWordString[8] = &quot;grey&quot;
        set PlayerColorString[9] = &quot;|c007dbef1&quot;
        set RedString[9] = 0x7d
        set GreenString[9] = 0xbe
        set BlueString[9] = 0xf1
        set PlayerColorWordString[9] = &quot;lightblue&quot;
        set PlayerColorString[10] = &quot;|c000f6145&quot;
        set RedString[10] = 0x0f
        set GreenString[10] = 0x61
        set BlueString[10] = 0x45
        set PlayerColorWordString[10] = &quot;darkgreen&quot;
        set PlayerColorString[11] = &quot;|c004d2903&quot;
        set RedString[11] = 0x4d
        set GreenString[11] = 0x29
        set BlueString[11] = 0x03
        set PlayerColorWordString[11] = &quot;brown&quot;

        set PlayerColorString[12] = &quot;|c00272727&quot;
        set RedString[12] = 0x27
        set GreenString[12] = 0x27
        set BlueString[12] = 0x27
        set PlayerColorWordString[12] = &quot;darkgrey&quot;
        
        set PlayerColorWordString[13] = &quot;gray&quot;
        set PlayerColorWordString[14] = &quot;aqua&quot;
        set PlayerColorWordString[15] = &quot;cyan&quot;
        set PlayerColorWordString[16] = &quot;darkgray&quot;
        set PlayerColorWordString[17] = &quot;neutral&quot;
    
        loop
            exitwhen i &lt; 0
            call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorWordString[ i ] ) / 20000000 + 96, Player( i ) )
            
            set i2 = GetHandleId( GetPlayerColor( Player( i ) ) )
            set PlayerColor<i> = PlayerColorString[i2]
            set Red<i> = RedString[i2]
            set Green<i> = GreenString[i2]
            set Blue<i> = BlueString[i2]
            set PlayerColorWord<i> = PlayerColorWordString<i>
            set i = i - 1
        endloop
        
        call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorWordString[ 13 ] ) / 20000000 + 96, Player( 8 ) )
        call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorWordString[ 14 ] ) / 20000000 + 96, Player( 2 ) )
        call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorWordString[ 15 ] ) / 20000000 + 96, Player( 2 ) )
        call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorWordString[ 16 ] ) / 20000000 + 96, Player( 12 ) )
        call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorWordString[ 17 ] ) / 20000000 + 96, Player( 12 ) )
        
    endfunction
    
endlibrary</i></i></i></i></i></i>

And it seems to be working
Is it how you meant ?

 

[Jesus4Lyf]

I'm fairly sure string hash will be impossible to fit into an array.

You're right because you didn't read my code.

call BJDebugMsg(I2S( StringHash(PlayerColorWordString<i>)/*This bit here makes it fit:*//29000000+73 ))</i>

Is it how you meant ?

return LoadPlayerHandle( StoredColors, 1, StringHash( StringCase( s, false ) ) / 20000000 + 96 )

I was suggesting, specifically, a way to avoid hashtables. (No.)

 

[Komaqtion]

Yeah, but how would I make an array link the PlayerColorWordString´[ 13 through 17 ] to the stuff they should be linked to ? :S

The only solution I see there is, hashtables...
But please, if you know of anything else, share it !

 

[Jesus4Lyf]

StringHash converts a string into an integer. You can, with some math, use the result in an array index

I don't think it's that hard. Do you need me to take my example and put an array in instead of BJDebugMsg(I2S(...))?

Edit: Well, just in case:

set myAttachmentArray[StringHash(myString)/29000000+73]=myValue // saving attachment
call DoSomethingWithResult(myAttachmentArray[StringHash(myString)/29000000+73]) // loading attachment

You must make sure there are no collisions with the math involved. That's all. (As in, each string you wish to attach to returns a unique value. Else divide by a lower number.)

 

[Komaqtion]

Ok, is this something of what you thought ?

library PlayerColors initializer Init


///////////////////////////////////////////////////////////////////////////////////////////////////////
//***************************************************************************************************//
//@@/////////////////////////////////// *//PlayerColorUtils\\* ////////////////////////////////////@@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%                 @@//
//@@                 %%                                                         %%                 @@//
//@@                 %%    //\\\\\               /////////  ///          \\\    %%                 @@//
//@@                 %%    //\\   \\\        //////         ///          \\\    %%                 @@//
//@@                 %%    //\\     \\\     /////           ///          \\\    %%                 @@//
//@@                 %%    //\\     ///   ////              ///          \\\    %%                 @@//
//@@                 %%    //\\   ///    ////               ///          \\\    %%                 @@//
//@@                 %%    //\\///      ////                ///          \\\    %%                 @@//
//@@                 %%    //\\         \\\\                ////        \\\\    %%                 @@//
//@@                 %%    //\\          \\\\               ////        \\\\    %%                 @@//
//@@                 %%    //\\           \\\\              ////        \\\\    %%                 @@//
//@@                 %%    //\\             \\\\\            ////      \\\\     %%                 @@//
//@@                 %%    //\\               \\\\\\          ////    \\\\      %%                 @@//
//@@                 %%    //\\                  \\\\\\\\\       ///\\\         %%                 @@//
//@@                 %%                                                         %%                 @@//
//@@                 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%                 @@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                                   Made by , Komaqtion                                         @@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                                        Purpose:                                               @@//
//@@                                                                                               @@//
//@@             ¤ This snippet is supposed to help people to, with ease, to use playercolors      @@//
//@@               in all aspects they'd possibly want.                                            @@//
//@@                                                                                               @@//
//@@                                         Usage:                                                @@//
//@@                                                                                               @@//
//@@             ¤ To use this snippet, simply type "call PlayerColoredString(playerid, string)"   @@//
//@@               where "string" is the string you want to colorize, and "playerid"               @@//
//@@               is the player number of the player, whose color you wan to use.                 @@//
//@@               Note: This uses JASS' player number range, meaning that                         @@//
//@@               Player 1(Red)'s number is 0, and Player 2(Blue)'s number is 1,                  @@//
//@@               and so on...                                                                    @@//
//@@               You can also get only the players color-string for own usage...                 @@//
//@@               This is accomplished by using the function "GetPlayerColorString"               @@//
//@@               which takes the player to get the string, or you can also use                   @@//
//@@               the GetPlayerColorStringById function, which takes the player's                 @@//
//@@               Id, or number instead <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin    :D" loading="lazy" data-shortname=":D" />                                                        @@//
//@@               You can also change the color of texttags using this snippet...                 @@//
//@@               The function is called &quot;PlayerColoredTextTag&quot; and takes integer alpha           @@//
//@@               which is transparency, player p, the playercolor you which to use, and          @@//
//@@               texttag tag which is the texttag you which to change the color of !             @@//
//@@               You can also use the function &quot;GetPlayerByColor&quot; which takes a string (color)   @@//
//@@               and returns the player which has that specific color. You can even type         @@//
//@@               &quot;ReD&quot; or &quot;REd&quot; or even &quot;..,,  R, e.., d&quot; and it&#039;ll return Player(0) or          @@//
//@@               player red in all three cases. And, you can also get the player&#039;s color         @@//
//@@               this way.                                                                       @@//
//@@                                                                                               @@//
//@@               WARNING: If you put an invalid player as an argument, in any of the functions,  @@//
//@@               it WILL return Player( 0 ), or Player &quot;Red&quot; !                                   @@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                                    Requirements:                                              @@//
//@@                                                                                               @@//
//@@             ¤ This snippet&#039;s only requirement is vJASS compilement, which is                  @@//
//@@               easiest achieved by downloading JASS Newgen Pack, at                            @@//
//@@               <a href="http://www.thehelper.net/forums/showthread.php?t=73936" class="link link--internal">http://www.thehelper.net/forums/showthread.php?t=73936</a>                          @@//
//@@               You&#039;ll also have to update JASS Helper to the latest version...                 @@//
//@@                                                                                               @@//
//@@                                                                                               @@//
//@@                                        Credits:                                               @@//
//@@                                                                                               @@//
//@@             ¤ Azlier, for helping me out alot with several bugfixes and tweaking !            @@//
//@@               Jesus4Lyf, for also helping me out alot ! <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin    :D" loading="lazy" data-shortname=":D" />                                    @@//
//@@               Quraji, for helping me add the &quot;GetPlayerByColor&quot; function ! <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin    :D" loading="lazy" data-shortname=":D" />                 @@//
//@@                                                                                               @@//
//@@               And credits, if you use this that is, is not needed to give me                  @@//
//@@               though it&#039;s always welcome <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink    ;)" loading="lazy" data-shortname=";)" />                                                   @@//
//@@                                                                                               @@//
//@@///////////////////////////////////////////////////////////////////////////////////////////////@@//
//***************************************************************************************************//
///////////////////////////////////////////////////////////////////////////////////////////////////////


    globals
        private integer array Red
        private integer array Green
        private integer array Blue
        private integer array RedString
        private integer array GreenString
        private integer array BlueString
        private string array PlayerColor
        private string array PlayerColorString
        private string array PlayerColorWord
        private string array PlayerColorWordString
        
        private hashtable StoredColors = InitHashtable()
        private player array StoredPlayers
        
        private constant string EndString = &quot;|r&quot;
    endglobals
    
    function PlayerColoredStringById takes integer playerId, string s returns string
        return PlayerColor[playerId] + s + EndString
    endfunction
    
    function PlayerColoredString takes player p, string s returns string
        return PlayerColor[GetPlayerId( p )] + s + EndString
    endfunction
    
    function PlayerColoredTextTag takes texttag tag, player p, integer alpha returns nothing
        local integer id = GetPlayerId( p )
        
        if p != null then
            call SetTextTagColor( tag, Red[id], Green[id], Blue[id], alpha )
        endif

    endfunction
    
    function PlayerColoredTextTagById takes texttag tag, integer playerId, integer alpha returns nothing
        call SetTextTagColor( tag, Red[playerId], Green[playerId], Blue[playerId], alpha )
    endfunction
    
    function GetPlayerColorString takes player p returns string
        return PlayerColor[GetPlayerId( p )]
    endfunction
    
    function GetPlayerColorStringById takes integer playerId returns string
        return PlayerColor[playerId]
    endfunction
    
    /*private function CompressString takes string compstring returns string
        local integer w = StringLength( compstring )
        local integer i = 0
        local string s = &quot;&quot;
        
        loop
        
                if SubString( compstring, i, i + 1 ) != &quot; &quot; or SubString( compstring, i, i + 1 ) != &quot;.&quot; or SubString( compstring, i, i + 1 ) != &quot;,&quot; then
                    set s = s + SubString( compstring, i, i + 1 )
                endif
                
            set i = i + 1
            
        exitwhen i &gt; w
        endloop
        
        return s
    endfunction*/
    
    function GetPlayerByColor takes string s returns player
        //return LoadPlayerHandle( StoredColors, 1, StringHash( StringCase( s, false ) ) / 20000000 + 96 )
        return StoredPlayers[ StringHash( StringCase( s, false ) ) / 20000000 + 96 ]
    endfunction
    
    function GetPlayerColorStringByColor takes string s returns string
        //return PlayerColor[ GetPlayerId( LoadPlayerHandle( StoredColors, 1, StringHash( StringCase( s, false ) ) / 20000000 + 96 ) ) ]
        return PlayerColor[ GetPlayerId( StoredPlayers[ StringHash( StringCase( s, false ) ) / 20000000 + 96 ] ) ]
    endfunction
    
    private function OnColorChange takes player whichPlayer, playercolor color returns nothing
        local integer id = GetPlayerId( whichPlayer )
        local integer pc = GetHandleId( color )

        set PlayerColor[id] = PlayerColorString[pc]
        set Red[id] = RedString[pc]
        set Green[id] = GreenString[pc]
        set Blue[id] = BlueString[pc]
        set PlayerColorWord[id] = PlayerColorWordString[pc]
        set StoredPlayers[ StringHash( PlayerColorWordString[ pc ] ) / 20000000 + 96 ] = whichPlayer
        
        //call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorString[ pc ] ) / 20000000 + 96, whichPlayer )
    endfunction
    
    hook SetPlayerColor OnColorChange
    
    private function Init takes nothing returns nothing
        local integer i = 12
        local integer i2
    
        set PlayerColorString[0] = &quot;|c00ff0202&quot;
        set RedString[0] = 0xff
        set GreenString[0] = 0x02
        set BlueString[0] = 0x02
        set PlayerColorWordString[0] = &quot;red&quot;
        set PlayerColorString[1] = &quot;|c000041ff&quot;
        set RedString[1] = 0x00
        set GreenString[1] = 0x41
        set BlueString[1] = 0xff
        set PlayerColorWordString[1] = &quot;blue&quot;
        set PlayerColorString[2] = &quot;|c001be5b8&quot;
        set RedString[2] = 0x1b
        set GreenString[2] = 0xe5
        set BlueString[2] = 0xb8
        set PlayerColorWordString[2] = &quot;teal&quot;
        set PlayerColorString[3] = &quot;|c00530080&quot;
        set RedString[3] = 0x53
        set GreenString[3] = 0x00
        set BlueString[3] = 0x80
        set PlayerColorWordString[3] = &quot;purple&quot;
        set PlayerColorString[4] = &quot;|c00fffc00&quot;
        set RedString[4] = 0xff
        set GreenString[4] = 0xfc
        set BlueString[4] = 0x00
        set PlayerColorWordString[4] = &quot;yellow&quot;
        set PlayerColorString[5] = &quot;|c00fe890d&quot;
        set RedString[5] = 0xfe
        set GreenString[5] = 0x89
        set BlueString[5] = 0x0d
        set PlayerColorWordString[5] = &quot;orange&quot;
        set PlayerColorString[6] = &quot;|c001fbf00&quot;
        set RedString[6] = 0x1f
        set GreenString[6] = 0xbf
        set BlueString[6] = 0x00
        set PlayerColorWordString[6] = &quot;green&quot;
        set PlayerColorString[7] = &quot;|c00e45aaf&quot;
        set RedString[7] = 0xe4
        set GreenString[7] = 0x5a
        set BlueString[7] = 0xaf
        set PlayerColorWordString[7] = &quot;pink&quot;
        set PlayerColorString[8] = &quot;|c00949596&quot;
        set RedString[8] = 0x94
        set GreenString[8] = 0x95
        set BlueString[8] = 0x96
        set PlayerColorWordString[8] = &quot;grey&quot;
        set PlayerColorString[9] = &quot;|c007dbef1&quot;
        set RedString[9] = 0x7d
        set GreenString[9] = 0xbe
        set BlueString[9] = 0xf1
        set PlayerColorWordString[9] = &quot;lightblue&quot;
        set PlayerColorString[10] = &quot;|c000f6145&quot;
        set RedString[10] = 0x0f
        set GreenString[10] = 0x61
        set BlueString[10] = 0x45
        set PlayerColorWordString[10] = &quot;darkgreen&quot;
        set PlayerColorString[11] = &quot;|c004d2903&quot;
        set RedString[11] = 0x4d
        set GreenString[11] = 0x29
        set BlueString[11] = 0x03
        set PlayerColorWordString[11] = &quot;brown&quot;

        set PlayerColorString[12] = &quot;|c00272727&quot;
        set RedString[12] = 0x27
        set GreenString[12] = 0x27
        set BlueString[12] = 0x27
        set PlayerColorWordString[12] = &quot;darkgrey&quot;
        
        set PlayerColorWordString[13] = &quot;gray&quot;
        set PlayerColorWordString[14] = &quot;aqua&quot;
        set PlayerColorWordString[15] = &quot;cyan&quot;
        set PlayerColorWordString[16] = &quot;darkgray&quot;
        set PlayerColorWordString[17] = &quot;neutral&quot;
    
        loop
            exitwhen i &lt; 0
            //call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorWordString[ i ] ) / 20000000 + 96, Player( i ) )
            
            set StoredPlayers[ StringHash( PlayerColorWordString[ i ] ) / 20000000 + 96 ] = Player( i )
            set i2 = GetHandleId( GetPlayerColor( Player( i ) ) )
            set PlayerColor<i> = PlayerColorString[ i2 ]
            set Red[ i ] = RedString[ i2 ]
            set Green[ i ] = GreenString[ i2 ]
            set Blue[ i ] = BlueString[ i2 ]
            set PlayerColorWord[ i ] = PlayerColorWordString[ i ]
            set i = i - 1
        endloop
        
        //call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorWordString[ 13 ] ) / 20000000 + 96, Player( 8 ) )
        //call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorWordString[ 14 ] ) / 20000000 + 96, Player( 2 ) )
        //call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorWordString[ 15 ] ) / 20000000 + 96, Player( 2 ) )
        //call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorWordString[ 16 ] ) / 20000000 + 96, Player( 12 ) )
        //call SavePlayerHandle( StoredColors, 1, StringHash( PlayerColorWordString[ 17 ] ) / 20000000 + 96, Player( 12 ) )
        
        set StoredPlayers[ StringHash( PlayerColorWordString[ 13 ] ) / 20000000 + 96 ] = Player( 8 )
        set StoredPlayers[ StringHash( PlayerColorWordString[ 14 ] ) / 20000000 + 96 ] = Player( 2 )
        set StoredPlayers[ StringHash( PlayerColorWordString[ 15 ] ) / 20000000 + 96 ] = Player( 2 )
        set StoredPlayers[ StringHash( PlayerColorWordString[ 16 ] ) / 20000000 + 96 ] = Player( 12 )
        set StoredPlayers[ StringHash( PlayerColorWordString[ 17 ] ) / 20000000 + 96 ] = Player( 12 )
    endfunction
    
endlibrary</i>

 

[Darthfett]

You may want to take a look at this:

http://www.thehelper.net/forums/showthread.php?p=1175160#post1175160

 

[Komaqtion]

Hehe, thanks !
Hmm... Hard choice there :S
Which way do you lean more at ?
Maybe we can somehow work this out together ?