System Quick Damage Detection

[Sevion]

Well, you know what I'd say.

Jam in Damage, AIDS and Event.

(I actually think that'd be damn impressive, but unfortunately it would require you to index units, and the GetType stuff with Damage wouldn't be practical for a GUI user so you probably couldn't use that. But you'd gain blocking!)

It's GUI

Implementing those kind of things isn't really smart. GUI'ers' heads would explode.

 

[Jesus4Lyf]

All the better.

>Implementing those kind of things isn't really smart. GUI'ers' heads would explode.
Don't worry, I understand and agree.

 

[oveRLuckEd]

hmm gj nice script

 

[Sunchips]

lol im pretty new to JASS how do I do if I want this for one of my abilities? Whenever a unit with the "Mana regen" buff deals damage to a unit it will regenerate mana

 

[Yoshii]

lol im pretty new to JASS how do I do if I want this for one of my abilities? Whenever a unit with the "Mana regen" buff deals damage to a unit it will regenerate mana

I already answered that using GUI I can even post the map; look at your GUI thread

 

[Jesus4Lyf]

You cannot do it leaklessly in GUI.

And this system isn't leakless.

Can I hear some kind of voice as to whether or not this needs to be reviewed, as it isn't leakless? It doesn't seem to pass criteria for being approved. =/

 

[Jesus4Lyf]

If this doesn't have its leak removed, it will be moved back to the tutorials and resources section to be reviewed again soon.

 

[Viikuna]

Its relative. It doesnt leak if you recycle your units. You can always say that system is fine and you just use it wrongly.

I dont really know anything about that rules stuff, because Im too lazy to real any forum rules ( I hope revealing this doesnt get me killed ), but I think you should think again these rules about cases like this.

edit. That GroupEnum with temporary group leaks yea, but few leaks in init function doesnt count.

 

[Azlier]

>It doesnt leak if you recycle your units.

One of the rules states that the system must be usable in any map without restriction.

>That GroupEnum with temporary group leaks yea, but few leaks in init function doesnt count.

Indeed. The real issue is that this leaks events.

Submissions with memory leaks will not be approved.

 

[Viikuna]

One of the rules states that the system must be usable in any map without restriction.

Bullshit. There aint system like that. It always requires a user that knows how to use system correctly. If there is some restriction, its users knowledge.

I mean where lies the line between users stupidy and systems shortage.

If some system requires you to destroy structs attached to some units, when unit is removed, and you dont do it, its ofc stupidy.

If some system requires you recycle units when they die, and you dont, its systems fault then? ( For me it looks like stupidy, but most of people would say otherwise )

IMO this leak is no problem as longer it is clearly stated in system information that each event this system creates takes some memory.

That should be enough.

Submissions with memory leaks will not be approved.

Systems naturally leak, if you dont use them properly.

Also, when Rising_Dusk released his damage etection system back in the day, he stated that it indeed leaks, but it is not really a problem, since he has used it in DoE and the map runs as smoothly as ever, so those leaks are insignifficantly small. Ofc you can argue about this all and I too think that even the smallest leak sucks, but not everybody does so.

And those your rules are clearly broken.

 

[Azlier]

>And those your rules are clearly broken.

Not my rules .

>There aint system like that.

It's the one rule that everyone breaks.

I have nothing against unfixable leaks (text messages), but this is a case where the leak can easily be removed.

 

[Jesus4Lyf]

IMO this leak is no problem as longer it is clearly stated in system information that each event this system creates takes some memory.

Personally, I wouldn't mind if this system at least noted it leaked (if the leak really is that minor ). I don't think it is right that it says nothing and leaks - the expectation of an approved resource on TH is that it does not leak, because the rules state that it is a requirement of approval.

Either way, if the author takes no action, this will have to be unapproved and reviewed.