Snippet Actions Per Minute

[RaiJin]

scope APM initializer i

globals
    private integer array APM
endglobals

private function APM_SHOW takes nothing returns boolean
    call DisplayTextToPlayer( GetTriggerPlayer(), 0, 0, "Your APM is: "+I2S(APM[GetPlayerId(GetTriggerPlayer())] ) )
    return false
endfunction

private function ACTS takes nothing returns boolean
    set APM[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))] = APM[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]+1
    return false
endfunction

private function RESET takes nothing returns nothing
    local integer index = 0
    loop
        set APM[index] = 0
        set index = index + 1
        exitwhen index == bj_MAX_PLAYER_SLOTS
    endloop
endfunction

private function i takes nothing returns nothing
    local trigger t     = CreateTrigger()
    local trigger t2    = CreateTrigger()
    local integer index = 0
    loop
        call TriggerRegisterPlayerUnitEvent( t,  Player(index), EVENT_PLAYER_UNIT_SELECTED,             null )
        call TriggerRegisterPlayerUnitEvent( t,  Player(index), EVENT_PLAYER_UNIT_ISSUED_ORDER,         null )
        call TriggerRegisterPlayerUnitEvent( t,  Player(index), EVENT_PLAYER_UNIT_ISSUED_POINT_ORDER,   null )
        call TriggerRegisterPlayerUnitEvent( t,  Player(index), EVENT_PLAYER_UNIT_ISSUED_TARGET_ORDER,  null )
        call TriggerRegisterPlayerUnitEvent( t,  Player(index), EVENT_PLAYER_UNIT_ISSUED_UNIT_ORDER,    null )
        call TriggerRegisterPlayerChatEvent( t2, Player(index), "-apm",                                 true )
        set APM[index] = 0
        set index = index + 1
        exitwhen index == bj_MAX_PLAYER_SLOTS
    endloop
    call TriggerAddCondition( t,  Condition( function ACTS     ))
    call TriggerAddCondition( t2, Condition( function APM_SHOW ))
    call TimerStart         ( CreateTimer(), 60.0, true, function RESET )
endfunction

endscope

if there's anything i missed please tell me

 

[Larcenist]

This isn't really an action per minute display, it's an action this minute display. This would probably be more of an APM-system if it displays the average amount of action throughout the whole game time (that is, total amount of orders divided by elapsed game time as a minute-factor).

Something like this is what I'd say an APM display is:

scope APM initializer Init

    globals
        private real array APM
        private boolean array Playing
        
        private timer T = CreateTimer()
        private real R = 0.
    endglobals
    
    private function Callback takes nothing returns nothing
        set R = R + 3600.
    endfunction
    
    private function GetGameTime takes nothing returns real
        return TimerGetElapsed(T)+R
    endfunction
    
    private function Handler takes nothing returns boolean
        local integer i = GetPlayerId(GetOwningPlayer(GetTriggerUnit()))
        
        set i:APM = i:APM + 1
        return false
    endfunction
    
    private function Display takes nothing returns boolean
        local integer i = 0
        loop
            if (i<img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue    :p" loading="lazy" data-shortname=":p" />laying) then
                call DisplayTextToPlayer(GetTriggerPlayer(), 0., 0., GetPlayerName(Player(i)) + &quot; APM is: &quot; + R2S(i:APM / (GetGameTime() / 60.)))
            endif
            
            set i = i + 1
            exitwhen i == bj_MAX_PLAYER_SLOTS
        endloop
        
        return false
    endfunction
    
    private function Leave takes nothing returns boolean
        set Playing[GetPlayerId(GetTriggerPlayer())] = false
        
        return false
    endfunction
    
    private function Init takes nothing returns nothing
        local trigger t = CreateTrigger()
        local trigger t2 = CreateTrigger()
        local trigger t3 = CreateTrigger()
        local integer i = 0
        loop
            if (GetPlayerController(Player(i)) == MAP_CONTROL_USER and GetPlayerSlotState(Player(i)) == PLAYER_SLOT_STATE_PLAYING) then
                call TriggerRegisterPlayerUnitEvent( t,  Player(i), EVENT_PLAYER_UNIT_SELECTED,             null )
                call TriggerRegisterPlayerUnitEvent( t,  Player(i), EVENT_PLAYER_UNIT_ISSUED_ORDER,         null )
                call TriggerRegisterPlayerUnitEvent( t,  Player(i), EVENT_PLAYER_UNIT_ISSUED_POINT_ORDER,   null )
                call TriggerRegisterPlayerUnitEvent( t,  Player(i), EVENT_PLAYER_UNIT_ISSUED_TARGET_ORDER,  null )
                call TriggerRegisterPlayerUnitEvent( t,  Player(i), EVENT_PLAYER_UNIT_ISSUED_UNIT_ORDER,    null )
                call TriggerRegisterPlayerChatEvent( t2, Player(i), &quot;-apm&quot;, true )
                call TriggerRegisterPlayerEvent(t3, Player(i), EVENT_PLAYER_LEAVE)
                
                set i:APM = 0.
                set i<img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue    :p" loading="lazy" data-shortname=":p" />laying = true
            else
                set i<img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue    :p" loading="lazy" data-shortname=":p" />laying = false
            endif
            
            set i = i + 1
            exitwhen i == bj_MAX_PLAYER_SLOTS
        endloop
        
        call TriggerAddCondition(t, Condition(function Handler))
        call TriggerAddCondition(t2, Condition(function Display))
        call TriggerAddCondition(t3, Condition(function Leave))
        call TimerStart(T, 3600., true, function Callback)
    endfunction
endscope

 

[Dinowc]

yes

make 2 separate integers

one which will count actions
and another which will count minutes

and then divide those 2 integers to get an actual average value

just remove the RESET function

btw this should also include when a player starts a research, buys/sells an item, unit, types a message (excluding the -apm message)...

 

[Troll-Brain]

There is no way to make a good apm system, because you can't make the difference with orders given with one or two clicks.
And they are undetectable orders , like when an unit receive the order to put an item on the floor.

You have also to handle better selections, but this you can do it with a timer to detect if it's a multi selection or a single selection.

 

[Jesus4Lyf]

On your reset function shift the APM to a cache, have your -apm thing read from that cache. So it gets APM for the previous minute. There's much better ways to do this, like letting each action increase the stack height (apm) for exactly 1 minute. That will let you know exactly how many actions you've had in the last minute. Makes the most sense.

 

[Jesus4Lyf]

Unfortunately this wasn't well done, and the author seems to have lost interest...

Graveyarded.

I'd like to see one of these approved that tells you exactly how many actions you've had in the last minute, or something...