System Quick Damage Detection

[RaiJin]

Quick Damage Detection​

library QDD initializer init requires Event

//$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$
//$                     Quick Damage Detection                                 $
//$                          Version 1.05                                      $
//$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$
//$                                                                            $
//$                                                                            $
//$    CREATOR - RaiJin                                                        $
//$                                                                            $
//$    HOW TO IMPORT:                                                          $
//$        Simply make a new trigger rename it to QDD and copy                 $
//$        copy and paste this in                                              $
//$                                                                            $
//$    CREDITS: -Vex for JASS NEWGEN PACK                                      $
//$             - JESUS4LYF for letting me use Event <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile    :)" loading="lazy" data-shortname=":)" />                        $
//$             - Tom Jones for his help                                       $
//$             - Romek for reminding me to add a function                     $
//$                                                                            $
//$                                                                            $
//$    Version 1.02 has a complete new revamp !!!                              $
//$                                                                            $
//$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$


globals
    private trigger QDD_Trigger = CreateTrigger()
    private Event QDD_Event
endglobals

function TriggerRegisterAnyUnitDamaged takes trigger t returns nothing
    call QDD_Event.register(t)
endfunction

private function LoopingThrough takes nothing returns boolean
    call QDD_Event.fire()
    return false
endfunction

private function INIT_GROUP takes nothing returns boolean
    call TriggerRegisterUnitEvent(QDD_Trigger, GetFilterUnit(), EVENT_UNIT_DAMAGED)
    return false
endfunction

private function init takes nothing returns nothing
    local group g = CreateGroup()
    local region r = CreateRegion()
    call RegionAddRect(r, bj_mapInitialPlayableArea)
    call TriggerRegisterEnterRegion(CreateTrigger(), r, Condition(function INIT_GROUP))
    call GroupEnumUnitsInRect(g, bj_mapInitialPlayableArea, Condition(function INIT_GROUP))
    call TriggerAddCondition(QDD_Trigger, Condition(function LoopingThrough))
    set QDD_Event = Event.create()
    call DestroyGroup(g)
    set g = null
endfunction

endlibrary

Heres a link to Jesus4lyfe's Event system Props to him for making it

http://www.thehelper.net/forums/showthread.php?t=126846

function TriggerRegisterAnyUnitDamaged takes trigger t returns nothing // like event
//Use the event responses to get the units

 

[Romek]

You missed out the most essential function of any damage detection:
TriggerRegisterAnyUnitDamaged (or w/e you want to call it).

 

[Cohadar]

Ye cause naming it slow dd would not be so smart

 

[RaiJin]

You missed out the most essential function of any damage detection:
TriggerRegisterAnyUnitDamaged (or w/e you want to call it).

shit i knew i was forgetting something loool ill do that right now

@Cohadar: exactly

 

[Jesus4Lyf]

>Vex for JASS NEWGEN PACK
This is wrong and (imo) irrelevant. Vex did not write the NewGen pack, just JassHelper.

Once again, like every other system where the author doesn't use Event so far, the event structure is incorrect and will not actually function in the expected manner. I don't know why you made it only run actions either, as these are generally frowned upon anyway. If you can't stand having requirements for this system, at least embed Event into this, but it is preferred to just require it for the sake of reduced code duplication and any updates or anything.

>function TriggerAddAction(QDD_Trigger, function userfunc)
I'd make it TriggerRegisterAnyUnitDamaged and make it take a trigger. Then you can use dynamic triggers... :thup:

 

[_whelp]

Cool, but looks a bit weird...

 

[RaiJin]

>Vex for JASS NEWGEN PACK
This is wrong and (imo) irrelevant. Vex did not write the NewGen pack, just JassHelper.

Once again, like every other system where the author doesn't use Event so far, the event structure is incorrect and will not actually function in the expected manner. I don't know why you made it only run actions either, as these are generally frowned upon anyway. If you can't stand having requirements for this system, at least embed Event into this, but it is preferred to just require it for the sake of reduced code duplication and any updates or anything.

>function TriggerAddAction(QDD_Trigger, function userfunc)
I'd make it TriggerRegisterAnyUnitDamaged and make it take a trigger. Then you can use dynamic triggers... :thup:

Ok ill implement Event in this and

>it looks a bit weird
what do u mean? you can at least tell me what looks "weird"

 

[Azlier]

You may want to know that this doesn't work with the latest patch. Blizzard killed H2I.

 

[RaiJin]

You may want to know that this doesn't work with the latest patch. Blizzard killed H2I.

WAAAAH REALLY? omg that sucks lol !

 

[Romek]

> WAAAAH REALLY? omg that sucks lol !
No it doesn't.

There's a native H2I, as well as 96 other new natives, and a new handle type.

 

[RaiJin]

oh interesting lol

> theres a native H2I, as well as 96 other new natives, and a new handle type.
really? so blizzard updated the editor?

 

[Romek]

See the announcement for more information.

 

[Sevion]

function QDD_DisableUnit takes unit whichUnit returns nothing
function QDD_EnableUnit takes unit whichUnit returns nothing

Um. Why?

function QDD_ConfigUnit takes unit whichUnit, boolean switch returns nothing
    if whichUnit == null then
        debug call BJDebugMsg("NULL UNIT !! make sure its not")
        return
    endif
    set disable[GetUnitValue(whichUnit)] = switch
endfunction

 

[RaiJin]

kk i completely changed the system

BUMP

 

[Sevion]

function TriggerRegisterAnyUnitDamaged takes trigger t returns nothing
    debug if t == null then
    debug   call BJDebugMsg("Null trigger passed!!!")
    debug   return
    debug endif
    set trigger_execute[trigger_count] = t
    set trigger_count = trigger_count + 1
endfunction

Why debug?

You're going to allow them to pass null triggers?

function TriggerRegisterAnyUnitDamaged takes trigger t returns nothing
    if t == null then
debug   call BJDebugMsg("Null trigger passed!!!")
    return
    endif
    set trigger_execute[trigger_count] = t
    set trigger_count = trigger_count + 1
endfunction

 

[RaiJin]

function TriggerRegisterAnyUnitDamaged takes trigger t returns nothing
    debug if t == null then
    debug   call BJDebugMsg("Null trigger passed!!!")
    debug   return
    debug endif
    set trigger_execute[trigger_count] = t
    set trigger_count = trigger_count + 1
endfunction

Why debug?

You're going to allow them to pass null triggers?

function TriggerRegisterAnyUnitDamaged takes trigger t returns nothing
    if t == null then
debug   call BJDebugMsg("Null trigger passed!!!")
    return
    endif
    set trigger_execute[trigger_count] = t
    set trigger_count = trigger_count + 1
endfunction

who would pass a null trigger in the first place?

 

[Artificial]

//
    set LastDamagedUnit = GetTriggerUnit()
    set LastDamagingUnit = GetEventDamageSource()
    set LastDamageCount = GetEventDamage()

You know, they could just use the event responses directly. ^_^

I think you should make sure the trigger isn't disabled before evaluating/executing it (otherwise damaging a unit inside an action/condition of a trigger evaluated/executed by this will cause an infinite loop even if you disable the trigger).

And why did you make it not register buildings? o_o Did they offend you? ;o

And IMO this seems to be rather similar to this (dunno if anyone else feels this way, though). x)

 

[Sevion]

who would pass a null trigger in the first place?

That isn't the point?

 

[RaiJin]

//
    set LastDamagedUnit = GetTriggerUnit()
    set LastDamagingUnit = GetEventDamageSource()
    set LastDamageCount = GetEventDamage()

You know, they could just use the event responses directly. ^_^

I think you should make sure the trigger isn't disabled before evaluating/executing it (otherwise damaging a unit inside an action/condition of a trigger evaluated/executed by this will cause an infinite loop even if you disable the trigger).

And why did you make it not register buildings? o_o Did they offend you? ;o

And IMO this seems to be rather similar to this (dunno if anyone else feels this way, though). x)

WAAAH it actually does loool xD and event responses would still work? ill update it soon then

@sevion then whats the point?

 

[Sevion]

The point is, users can pass null triggers...

And guess what? The last time I checked, that ISN'T good.

Do you follow me?