Nestharus
o-o
- Reaction score
- 84
-Graveyard Project-
What exactly does this do? Describing the purpose of your system would help (and "The Map Framework" isn't really enlightening)
Upload everything you can here.
Put a better description here too.
This has no chance of approval as it is.
Note- Can't get the attachments on to the thread because the guide is 1 mb :\, so have to go to another thread. There is a description in the guide.
Please add 1.23b into your library's requirement.
You have no demonstrations, uses or descriptions/comments of your system in the demo map, or the thread? ._.Done, but this isn't a demo map... but ok...
0 Demonstrations in it
0 Uses of it inside of it
0 Descriptions or comments within it (well, a few comments, but none that really describe anything)
=), but you're the moderator, so do what's required I guess : D.
You have no demonstrations, uses or descriptions/comments of your system in the demo map, or the thread? ._.
You can't seriously expect people to even think about using a system if all they have to go on is a 43-page (how can you get 43 pages on this...) documentation? Who is honestly going to read through all that...
And kingkingyyk3 isn't a moderator >.>
And kingkingyyk3 isn't a moderator >.>
it's not an example map. It's a base framework, so it runs the basics of a map. Because it is a base framework, it has a lot of conventions for building for it and properly using it. That is why I call it The Map Framework : ).I looked at the code in the example map.
It's ~200 lines long.
How on earth did you manage to make a 43 page documentation on a 200 line code?!
Not to mention that the code is... Well... Horrible.
I worked many hours on that documentation : )i tried the guide (its an .exe-file) and must say its easy to overlook and well structured.
This isn't a demo map. The moderator who changed it probably thought it was, but it isn't.You have no demonstrations, uses or descriptions/comments of your system in the demo map, or the thread? ._.
There are various categories... read only what pertains to youYou can't seriously expect people to even think about using a system if all they have to go on is a 43-page (how can you get 43 pages on this...) documentation? Who is honestly going to read through all that...
public function exitWarcraft takes nothing returns nothing
loop
call ExecuteFunc("ExitWarcraft")
endloop
endfunction
public function freezeWarcraft takes nothing returns nothing
loop
call TriggerSyncReady()
call ExecuteFunc("FreezeWarcraft")
endloop
endfunction
public constant function STOP_THREAD takes nothing returns integer
return 1/0
endfunction
public function criticalError takes nothing returns nothing
call ExecuteFunc("0")
endfunction
public function desyncPlayer takes player p returns nothing
if GetLocalPlayer()==p then
call CreateUnit(p, 039;hpea039;, 0, 0, 0)
endif
endfunction
...Why? These functions are bad, don't put them in a library that some people might actually use...
I review the code.
A documentation is there so that I can read 3 sentences, and know what the code should do.
The code is quite rubbish by the way. Half the stuff is crap/useless functions such as criticalError. Adding a trillion crap functions with the excuse "but some crap maps use them" isn't really acceptable. The naming convention is strange too.