System Custom Day and Night System

SanKakU · Nov 27, 2009

I'm not prepared yet to post a test map, as I think the code can be improved, and i haven't yet worked on terrain or whatever for a test map...

i am using the system and it works great...but seeing as the code can probably be improved, i want to post that here, and get some input on that. then i can make a test map and submit it if things look good.

trigger called initial lighting day

JASS:

//this is according to how long the day is...
//because it starts at 13 and war3 automarically has dusk at 18
//and there&#039;s nothing you can do about that...
//instead of bothering with war3&#039;s imperfect midnight...
//this system uses only dusk and dawn...when it&#039;s dawn, it&#039;s dawn
//and to make matters simple, at game start it is dawn...that&#039;s what this trigger does
//it sets the game start time to dawn.
//you can change the sound if you like to whatever you want.
//go to sound editor, find a sound you want, use it, and give it
//a variable name, my variable names were thelightiswithus and thenightbeckons
//edit:
//actually now that i think about it this is the best way i can think of, to start it
//at 13...because 23 is 5 from 18 as is 13.  and at 24 the game goes to 0
//you can of course change your numbers to like 23.5 and 12.5 if you want...
//that&#039;s up to you.  or you can make the day shorter!  haha.
//of course you can also change the speed of the day too, so making the days
//ten hours long isn&#039;t so bad, you can choose to make the day longer.
//i believe you have to use the map&#039;s gameplay constants to do that.
function Trig_initialweatherday_Actions takes nothing returns nothing
set bj_dawnSound = gg_snd_thelightiswithus//this is my custom dawn sound
set bj_duskSound = gg_snd_thenightbeckons//this is my custom dusk/sunset sound
    call SetFloatGameState(GAME_STATE_TIME_OF_DAY, 13.00)
endfunction

//===========================================================================
function InitTrig_initiallightingday takes nothing returns nothing
    set gg_trg_initiallightingday = CreateTrigger(  )
    call TriggerAddAction( gg_trg_initiallightingday, function Trig_initialweatherday_Actions )
endfunction

trigger called night and day

JASS:

//I&#039;m submitting this system in hopes that people will recommend how it can be improved, but also because
//nobody tried to make a system like this and i think it&#039;s very useful.

scope customdayandnightsystem initializer I
globals
private trigger t3 = CreateTrigger()//daydawnabilitychanges
private trigger t2 = CreateTrigger()//nightfallabilitychanges
private trigger t1 = CreateTrigger()//clockadjustment

//these auras are just set aside for when i need them, they have nothing to do with the
// custom day and night system
constant integer TerrorAura =&#039;A047&#039;
constant integer BrillianceAura =&#039;A03D&#039;
constant integer EnduranceAura =&#039;A03E&#039;
constant integer WarDrumsAura =&#039;A03I&#039;
constant integer UnholyAura=&#039;A03F&#039;
constant integer VampiricAura =&#039;A03G&#039;
constant integer SlowAura=&#039;A03H&#039;
constant integer GeneralAuraDummy =&#039;AGnA&#039;

//these are the ability and buff codes that the day and night system uses
//your abilities will probably be different, as may be your ability replacing actions...
constant integer DestroyEnergyDummy =&#039;A00Q&#039;
constant integer DestroyMagicDummy =&#039;A00P&#039;
constant integer DestroyEnergy =&#039;A00S&#039;
constant integer DestroyMagic =&#039;A00N&#039;
constant integer DispelMagicNormal=&#039;A00O&#039;
constant integer HeightenedAgilityOFFDAY=&#039;A006&#039;
constant integer HeightenedAgilityOFFNIGHT=&#039;A005&#039;
constant integer HeightenedAgilityONDAY=&#039;A004&#039;
constant integer HeightenedAgilityONNIGHT=&#039;A002&#039;
constant integer HeightenedAgilityDUMMYDAY =&#039;A00D&#039;
constant integer HeightenedAgilityDUMMYNIGHT =&#039;A00E&#039;
constant integer TimeOfDayAgilityItem =&#039;A00I&#039;
constant integer DayStrikeDummy =&#039;A00F&#039;
constant integer NightStrikeDummy=&#039;A00B&#039;
constant integer ColdStrikeNIGHT=&#039;A008&#039;
constant integer HeatStrikeDAY =&#039;A00A&#039;
constant integer NightStrikeDAY=&#039;A007&#039;
constant integer DayStrikeNIGHT =&#039;A009&#039;
constant integer NIGHTWALK=&#039;B000&#039;
constant integer DAYWALK =&#039;B001&#039;
constant integer ColdStorm =&#039;A00K&#039;
constant integer AvengingFlames =&#039;A00M&#039;



//UNUSED?//i&#039;m not sure what these are for but i guess i don&#039;t trigger them, but somewhere
//they have something to do with the abilities in the day and night system...
constant integer DAYAGILITY=&#039;B002&#039;
constant integer NIGHTAGILITY =&#039;B003&#039;


endglobals
//textmacro time
//! textmacro RemoveUnitsFromGroup takes UNIT, GROUP
    loop
        set $UNIT$ = FirstOfGroup($GROUP$)
        exitwhen $UNIT$ == null
        call GroupRemoveUnit($GROUP$, PickedUnit)
    endloop
//! endtextmacro
//! textmacro groupup takes prefix
call GroupEnumUnitsInRect(g, bj_mapInitialPlayableArea,Condition(function $prefix$filter))
    call ForGroup(g, function $prefix$act )
//! endtextmacro
//! textmacro groupupd takes prefix
call GroupEnumUnitsInRect(g, bj_mapInitialPlayableArea,Condition(function $prefix$filter))
    call ForGroup(g, function $prefix$actd )
//! endtextmacro

//this section will probably look different for you
//feel free rename the functions and variables and whatever
//basically, these are the functions called when night time comes.
private function agilnfilter takes nothing returns boolean
    return ( GetUnitAbilityLevel( GetFilterUnit(), HeightenedAgilityDUMMYNIGHT) &gt; 0 )
endfunction

private function agilnact takes nothing returns nothing
    call UnitRemoveAbility(GetEnumUnit(), HeightenedAgilityOFFNIGHT)
    call UnitAddAbility(GetEnumUnit(), HeightenedAgilityONNIGHT)
    call SetUnitAbilityLevel(GetEnumUnit(), HeightenedAgilityONNIGHT, GetUnitAbilityLevel(GetEnumUnit(),HeightenedAgilityDUMMYNIGHT) )
    call UnitAddAbility(GetEnumUnit(), TimeOfDayAgilityItem)
    call SetUnitAbilityLevel(GetEnumUnit(), TimeOfDayAgilityItem, GetUnitAbilityLevel(GetEnumUnit(),HeightenedAgilityDUMMYNIGHT) )
endfunction

private function nsfilter takes nothing returns boolean
    return ( GetUnitAbilityLevel(GetFilterUnit(),NightStrikeDummy) &gt; 0 )
endfunction

private function nsact takes nothing returns nothing
    call UnitRemoveAbility(GetEnumUnit(), NightStrikeDAY )
    call UnitAddAbility(GetEnumUnit(), ColdStrikeNIGHT )
    call SetUnitAbilityLevel(GetEnumUnit(), ColdStrikeNIGHT, GetUnitAbilityLevel(GetEnumUnit(),NightStrikeDummy) )
endfunction

private function agildfilter takes nothing returns boolean
    return ( GetUnitAbilityLevel(GetFilterUnit(),HeightenedAgilityDUMMYDAY) &gt; 0 )
endfunction

private function agildact takes nothing returns nothing
    call UnitRemoveAbility(GetEnumUnit(), HeightenedAgilityONDAY )
    call UnitAddAbility(GetEnumUnit(), HeightenedAgilityOFFDAY )
    call SetUnitAbilityLevel(GetEnumUnit(), HeightenedAgilityOFFDAY, GetUnitAbilityLevel(GetEnumUnit(),HeightenedAgilityDUMMYDAY) )
    call UnitRemoveAbility(GetEnumUnit(), TimeOfDayAgilityItem )
endfunction

private function dsfilter takes nothing returns boolean
    return ( GetUnitAbilityLevel(GetFilterUnit(),DayStrikeDummy) &gt; 0 )
endfunction

private function dsact takes nothing returns nothing
    call UnitRemoveAbility(GetEnumUnit(), HeatStrikeDAY )
    call UnitAddAbility(GetEnumUnit(), DayStrikeNIGHT )
    call SetUnitAbilityLevel(GetEnumUnit(), DayStrikeNIGHT, GetUnitAbilityLevel(GetEnumUnit(),DayStrikeDummy) )
endfunction

private function dmfilter takes nothing returns boolean
    return ( GetUnitAbilityLevel(GetFilterUnit(),DestroyMagicDummy) &gt; 0 )
endfunction

private function dmact takes nothing returns nothing
    call UnitRemoveAbility(GetEnumUnit(), DestroyMagic )
    call UnitAddAbility(GetEnumUnit(), DispelMagicNormal )
    call SetUnitAbilityLevel(GetEnumUnit(), DispelMagicNormal, GetUnitAbilityLevel(GetEnumUnit(),DestroyMagicDummy) )
endfunction

private function defilter takes nothing returns boolean
    return ( GetUnitAbilityLevel(GetFilterUnit(),DestroyEnergyDummy) &gt; 0 )
endfunction

private function deact takes nothing returns nothing
    call UnitRemoveAbility(GetEnumUnit(), DispelMagicNormal )
    call UnitAddAbility(GetEnumUnit(), DestroyEnergy )
    call SetUnitAbilityLevel(GetEnumUnit(), DestroyEnergy, GetUnitAbilityLevel(GetEnumUnit(),DestroyEnergyDummy) )
endfunction
//now we have the text macro, again, the names of the textmacro takes
//may probably look different for you...the only difference between
//these textmacro and the others is that they&#039;re calling the opposite functions
private function A takes nothing returns boolean
    local group g = CreateGroup()
    local unit PickedUnit = null
    
//Eithyr deserves credit for the textmacro RemoveUnitsFromGroup...
//i did not at that time understand textmacro
//i made the other textmacro after i found out how to make them
//Jesus4Lyf taught me textmacro, thanks.
//also this system is really retarded if you do not use
//preloading for your spells and abilities.
    
    //! runtextmacro groupup(&quot;agiln&quot;)
    //! runtextmacro RemoveUnitsFromGroup(&quot;PickedUnit&quot;, &quot;g&quot;)
    //! runtextmacro groupup(&quot;agild&quot;)
    //! runtextmacro RemoveUnitsFromGroup(&quot;PickedUnit&quot;, &quot;g&quot;)
    //! runtextmacro groupup(&quot;ns&quot;)
    //! runtextmacro RemoveUnitsFromGroup(&quot;PickedUnit&quot;, &quot;g&quot;)
    //! runtextmacro groupup(&quot;ds&quot;)
    //! runtextmacro RemoveUnitsFromGroup(&quot;PickedUnit&quot;, &quot;g&quot;)
    //! runtextmacro groupup(&quot;dm&quot;)
    //! runtextmacro RemoveUnitsFromGroup(&quot;PickedUnit&quot;, &quot;g&quot;)
    //! runtextmacro groupup(&quot;de&quot;)
    //! runtextmacro RemoveUnitsFromGroup(&quot;PickedUnit&quot;, &quot;g&quot;)
    set g = null
    return false
endfunction


//this section will probably look different for you
//feel free rename the functions and variables and whatever
//basically, these are the functions called when day time comes.

private function agilnactd takes nothing returns nothing
    call UnitRemoveAbility(GetEnumUnit(), HeightenedAgilityONNIGHT )
    call UnitAddAbility(GetEnumUnit(), HeightenedAgilityOFFNIGHT )
    call SetUnitAbilityLevel(GetEnumUnit(), HeightenedAgilityOFFNIGHT, GetUnitAbilityLevel(GetEnumUnit(),HeightenedAgilityDUMMYNIGHT) )
    call UnitRemoveAbility(GetEnumUnit(), TimeOfDayAgilityItem )
endfunction

private function nsactd takes nothing returns nothing
    call UnitRemoveAbility(GetEnumUnit(), ColdStrikeNIGHT )
    call UnitAddAbility(GetEnumUnit(), NightStrikeDAY )
    call SetUnitAbilityLevel(GetEnumUnit(), NightStrikeDAY, GetUnitAbilityLevel(GetEnumUnit(),NightStrikeDummy) )
endfunction

private function dsactd takes nothing returns nothing
    call UnitRemoveAbility(GetEnumUnit(), DayStrikeNIGHT )
    call UnitAddAbility(GetEnumUnit(), HeatStrikeDAY )
    call SetUnitAbilityLevel(GetEnumUnit(), HeatStrikeDAY, GetUnitAbilityLevel(GetEnumUnit(),DayStrikeDummy) )
endfunction

private function agildactd takes nothing returns nothing
    call UnitRemoveAbility(GetEnumUnit(), HeightenedAgilityOFFDAY )
    call UnitAddAbility(GetEnumUnit(), HeightenedAgilityONDAY )
    call SetUnitAbilityLevel(GetEnumUnit(), HeightenedAgilityONDAY, GetUnitAbilityLevel(GetEnumUnit(),HeightenedAgilityDUMMYDAY) )
    call UnitAddAbility(GetEnumUnit(), TimeOfDayAgilityItem )
    call SetUnitAbilityLevel(GetEnumUnit(), TimeOfDayAgilityItem, GetUnitAbilityLevel(GetEnumUnit(),HeightenedAgilityDUMMYDAY) )
endfunction

private function dmactd takes nothing returns nothing
    call UnitRemoveAbility(GetEnumUnit(), DispelMagicNormal )
    call UnitAddAbility(GetEnumUnit(), DestroyMagic )
    call SetUnitAbilityLevel(GetEnumUnit(), DestroyMagic, GetUnitAbilityLevel(GetEnumUnit(),DestroyMagicDummy) )
endfunction

private function deactd takes nothing returns nothing
    call UnitRemoveAbility(GetEnumUnit(), DestroyEnergy )
    call UnitAddAbility(GetEnumUnit(), DispelMagicNormal )
    call SetUnitAbilityLevel(GetEnumUnit(), DispelMagicNormal, GetUnitAbilityLevel(GetEnumUnit(),DestroyEnergyDummy) )
endfunction
//now we have the text macro, again, the names of the textmacro takes
//may probably look different for you...the only difference between
//these textmacro and the others is that they&#039;re calling the opposite functions
private function a takes nothing returns boolean
    local group g = CreateGroup()
    local unit PickedUnit = null
    
//Eithyr deserves credit for the textmacro RemoveUnitsFromGroup...
//i did not at that time understand textmacro
//i made the other textmacro after i found out how to make them
//Jesus4Lyf taught me textmacro, thanks.
//also this system is really retarded if you do not use
//preloading for your spells and abilities.
    
    //! runtextmacro groupupd(&quot;agiln&quot;)
    //! runtextmacro RemoveUnitsFromGroup(&quot;PickedUnit&quot;, &quot;g&quot;)
    //! runtextmacro groupupd(&quot;agild&quot;)
    //! runtextmacro RemoveUnitsFromGroup(&quot;PickedUnit&quot;, &quot;g&quot;)
    //! runtextmacro groupupd(&quot;ns&quot;)
    //! runtextmacro RemoveUnitsFromGroup(&quot;PickedUnit&quot;, &quot;g&quot;)
    //! runtextmacro groupupd(&quot;ds&quot;)
    //! runtextmacro RemoveUnitsFromGroup(&quot;PickedUnit&quot;, &quot;g&quot;)
    //! runtextmacro groupupd(&quot;dm&quot;)
    //! runtextmacro RemoveUnitsFromGroup(&quot;PickedUnit&quot;, &quot;g&quot;)
    //! runtextmacro groupupd(&quot;de&quot;)
    //! runtextmacro RemoveUnitsFromGroup(&quot;PickedUnit&quot;, &quot;g&quot;)
    set g = null
    return false
endfunction
//see this one was called groupupd d meaning daytime version
//the other one is for nighttime.



//this function keeps it all together.  without it, custom day and night system is not possible
private function b takes nothing returns boolean
    call SetFloatGameState(GAME_STATE_TIME_OF_DAY, 13.00)//this 13.00 is dawn, the first minute of the day
    call StartSound(bj_dawnSound)//it&#039;s not really dawn without this sound...
    return false
endfunction

//===========================================================================
private function I takes nothing returns nothing

    call TriggerRegisterGameStateEventTimeOfDay( t1, GREATER_THAN_OR_EQUAL, 23.00 )//this is also dawn
    call TriggerAddCondition( t1, Condition( function b ) )//this calls the function that keeps it all together
    call TriggerRegisterGameStateEventTimeOfDay( t2, GREATER_THAN_OR_EQUAL, 18.00 )//this is dusk/sunset
    call TriggerAddCondition( t2, Condition( function A ) )//calling night time conditions because it&#039;s night
    call TriggerRegisterGameStateEventTimeOfDay( t3, LESS_THAN, 18.00 )//this is before dusk/sunset
    call TriggerAddCondition( t3, Condition( function a ) )//calling day time conditions because it&#039;s day
endfunction

endscope

an example trigger:

JASS:

//this is just an example of something you can do to enhance an ability if you wish...
//it&#039;s not a super awesome spell or anything...it&#039;s just checking for time of day and acting accordingly...
//of course you&#039;ll notice it&#039;s doing it by checking the ability, because the ability is swapped
//according to the time of day...it&#039;s all kindof complicated...hopefully the constant integer names
//help things to make more sense...

function Trig_strike_Actions takes nothing returns nothing
    if GetUnitAbilityLevel(GetAttacker(), NIGHTWALK) &gt;= 1 then
        call UnitDamageTarget( GetAttacker(), GetTriggerUnit(), ( ( GetUnitMoveSpeed(GetAttacker()) - GetUnitMoveSpeed(GetTriggerUnit()) ) * I2R(GetUnitAbilityLevel(GetAttacker(),NightStrikeDummy)) ), false, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, WEAPON_TYPE_WHOKNOWS )       
    else
    if GetUnitAbilityLevel(GetAttacker(), DAYWALK) &gt;= 1 then
        call UnitDamageTarget( GetAttacker(), GetTriggerUnit(), ( ( GetUnitMoveSpeed(GetAttacker()) - GetUnitMoveSpeed(GetTriggerUnit()) ) * I2R(GetUnitAbilityLevel(GetAttacker(),DayStrikeDummy)) ), false, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, WEAPON_TYPE_WHOKNOWS )
    endif
    endif
endfunction

//===========================================================================
function InitTrig_strike takes nothing returns nothing
    set gg_trg_strike = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_strike, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddAction( gg_trg_strike, function Trig_strike_Actions )
endfunction
//i might have to rewrite these spells with a different event...
//event unit damaged might do damage after windwalk disappears instead of before...
//another idea is to rewrite how much damage is done to creeps or heroes in order to
//balance things...one shotting all the creeps seems kindof unfair...?
//another thing to look at is if they are doing damage properly when not in windwalk mode...
//another idea is to give creeps additional hp, towers too...

oh wow, almost forgot this one...
it has other unrelated stuff in it, but it's a very important trigger that helps prevent bugs in the system...
the textmacro in this trigger can probably be used elsewhere in the other triggers, but it's sortof more critical here...doesn't make much of a difference, but it is a lot more pleasing to the eye using this textmacro ifnight and ifday...

JASS:

scope spellsEPHS initializer I




//! textmacro ifnight
if GetFloatGameState(GAME_STATE_TIME_OF_DAY) &gt;= 18.00 then
//! endtextmacro
//! textmacro ifday
if GetFloatGameState(GAME_STATE_TIME_OF_DAY) &lt; 18.00 then
//! endtextmacro

private function A takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local integer i = GetLearnedSkill()
    local integer ii= 0
    if i == NightStrikeDummy then
    //! runtextmacro ifnight()
    call UnitRemoveAbility(u, NightStrikeDAY)
    call UnitAddAbility(u, ColdStrikeNIGHT)
    call SetUnitAbilityLevel(u, ColdStrikeNIGHT, GetUnitAbilityLevel(u,i) )
    else
    call UnitRemoveAbility(u, ColdStrikeNIGHT)
    call UnitAddAbility(u, NightStrikeDAY)
    call SetUnitAbilityLevel( u, NightStrikeDAY, GetUnitAbilityLevel(u,i) )
    call SetUnitAbilityLevel( u, NightStrikeDAY, GetUnitAbilityLevel(u,i) )
    endif
    elseif i == HeightenedAgilityDUMMYNIGHT then
    //! runtextmacro ifnight()
    call UnitRemoveAbility(u, HeightenedAgilityOFFNIGHT)
    call UnitAddAbility(u, HeightenedAgilityONNIGHT)
    call SetUnitAbilityLevel( u,HeightenedAgilityONNIGHT,  GetUnitAbilityLevel(u,i) )
    call UnitAddAbility(u, TimeOfDayAgilityItem)
    call SetUnitAbilityLevel( u,TimeOfDayAgilityItem,  GetUnitAbilityLevel(u,i) )
    else
    call UnitRemoveAbility(u, TimeOfDayAgilityItem)
    call UnitRemoveAbility(u, HeightenedAgilityONNIGHT)
    call UnitAddAbility(u, HeightenedAgilityOFFNIGHT)
    call SetUnitAbilityLevel(u, HeightenedAgilityOFFNIGHT, GetUnitAbilityLevel(u,i) )
    endif
    elseif i == DestroyEnergyDummy then
    //! runtextmacro ifnight()
    call UnitRemoveAbility(u, DispelMagicNormal)
    call UnitAddAbility(u, DestroyEnergy)
    call SetUnitAbilityLevel(u, DestroyEnergy, GetUnitAbilityLevel(u,i) )
    else
    call UnitRemoveAbility(u, DestroyEnergy)
    call UnitAddAbility(u, DispelMagicNormal)
    call SetUnitAbilityLevel(u, DispelMagicNormal, GetUnitAbilityLevel(u,i) )
    endif
    elseif i == DayStrikeDummy then
    //! runtextmacro ifday()
    call UnitRemoveAbility(u, DayStrikeNIGHT)
    call UnitAddAbility(u, HeatStrikeDAY)
    call SetUnitAbilityLevel(u, HeatStrikeDAY, GetUnitAbilityLevel(u,i) )
    else
    call UnitRemoveAbility(u, HeatStrikeDAY)
    call UnitAddAbility(u, DayStrikeNIGHT)
    call SetUnitAbilityLevel( u, DayStrikeNIGHT, GetUnitAbilityLevel(u,i) )
    endif
    elseif i == HeightenedAgilityDUMMYDAY then
    //! runtextmacro ifday()
    call UnitRemoveAbility(u, HeightenedAgilityOFFDAY)
    call UnitAddAbility(u, HeightenedAgilityONDAY)
    call SetUnitAbilityLevel( u,HeightenedAgilityONDAY,  GetUnitAbilityLevel(u,i) )
    call UnitAddAbility(u, TimeOfDayAgilityItem)
    call SetUnitAbilityLevel( u,TimeOfDayAgilityItem,  GetUnitAbilityLevel(u,i) )
    else
    call UnitRemoveAbility(u, TimeOfDayAgilityItem)
    call UnitRemoveAbility(u, HeightenedAgilityONDAY)
    call UnitAddAbility(u, HeightenedAgilityOFFDAY)
    call SetUnitAbilityLevel(u, HeightenedAgilityOFFDAY, GetUnitAbilityLevel(u,i) )
    endif
    elseif i == DestroyMagicDummy then
    //! runtextmacro ifday()
    call UnitRemoveAbility(u, DispelMagicNormal)
    call UnitAddAbility(u, DestroyMagic)
    call SetUnitAbilityLevel(u, DestroyMagic, GetUnitAbilityLevel(u,i) )
    else
    call UnitRemoveAbility(u, DestroyMagic)
    call UnitAddAbility(u, DispelMagicNormal)
    call SetUnitAbilityLevel(u, DispelMagicNormal, GetUnitAbilityLevel(u,i) )
    endif
    elseif i == &#039;A011&#039; then//cntrlmgc
    call UnitAddAbility(u, &#039;A010&#039;)//spllstl
    call SetUnitAbilityLevel(u, &#039;A010&#039;, GetUnitAbilityLevel(u,i) )
    elseif i == &#039;A01H&#039; then//unholyaura(sinister)
    call SetUnitAbilityLevel(u, &#039;A01I&#039;, (GetUnitAbilityLevel(u,i)+1) )//raisedead
    elseif i == &#039;A04R&#039; then//fieryfury
    call AddPlayerTechResearched(GetOwningPlayer(u),&#039;R00B&#039;,1)//lavalordatkspdbns
    endif
    set u = null
endfunction

//===========================================================================
private function I takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    local integer index = 2
    loop
    call TriggerRegisterPlayerUnitEvent( t, Player(index),EVENT_PLAYER_HERO_SKILL, Filter(function FilterDebug) )
    set index = index + 1
    exitwhen index == 11
    endloop
    call TriggerAddAction( t, function A )
   // set bj_lastCreatedUnit = CreateUnit(Player(PLAYER_NEUTRAL_PASSIVE), &#039;e008&#039;, 380, 380, 0)
    call XE_PreloadAbility( &#039;A01H&#039;)
    call XE_PreloadAbility( &#039;A011&#039;)
    call XE_PreloadAbility( DestroyMagicDummy)
    call XE_PreloadAbility( HeightenedAgilityDUMMYDAY)
    call XE_PreloadAbility( DayStrikeDummy)
    call XE_PreloadAbility( DestroyEnergyDummy)
    call XE_PreloadAbility( HeightenedAgilityDUMMYNIGHT)
    call XE_PreloadAbility( NightStrikeDummy)
    call XE_PreloadAbility( ColdStrikeNIGHT)
    call XE_PreloadAbility( NightStrikeDAY)
    call XE_PreloadAbility( HeightenedAgilityONNIGHT)
    call XE_PreloadAbility( TimeOfDayAgilityItem)
    call XE_PreloadAbility( HeightenedAgilityOFFNIGHT)
    call XE_PreloadAbility( DispelMagicNormal)
    call XE_PreloadAbility( DestroyEnergy)
    call XE_PreloadAbility( DayStrikeNIGHT)
    call XE_PreloadAbility( HeatStrikeDAY)
    call XE_PreloadAbility( HeightenedAgilityOFFDAY)
    call XE_PreloadAbility( HeightenedAgilityONDAY)
    call XE_PreloadAbility( DestroyMagic)
    call XE_PreloadAbility( &#039;A010&#039;)
    call XE_PreloadAbility( &#039;A01I&#039;)
    call XE_PreloadAbility( &#039;A04R&#039;)
    call XE_PreloadAbility( &#039;R00B&#039;)
    call XE_PreloadAbility( &#039;A06H&#039;)
    call XE_PreloadAbility( &#039;A066&#039;)
 //   call KillUnit(bj_lastCreatedUnit)
endfunction

endscope

as you can see right now my system is currently using libraries and such like xepreload or even taf which is my map's special library...

i think i can definitely improve on my system but i don't really know where to start...
oh and here's a snippet from a crazy trigger i've been working on combining many spells into one event spell effect trigger...it might not be a good idea but whatever...as you can see it's a simple dummy cast thing if and only if the spell is being cast at a proper time of day...think like night stalker and using one of his spells that has a greater impact at night time...
well with my system you can do it for a day time dude too...not just night time...that's the entire point of this day and night system.

JASS:

    //flame storm speedup effect
    //made by SanKakU so please give credits if you use this spell in your map
    else
    if i == AvengingFlames then
    if GetFloatGameState(GAME_STATE_TIME_OF_DAY) &lt; 18.00 then
    set u = CreateUnit(GetOwningPlayer(GetSpellAbilityUnit()), &#039;e000&#039;, ux, uy, 270.00)
    call UnitAddAbility(u, &#039;A00Z&#039;)
    call SetUnitAbilityLevel(u, &#039;A00Z&#039;, GetUnitAbilityLevel(GetSpellAbilityUnit(),AvengingFlames))
    call UnitApplyTimedLife(u, &#039;BTLF&#039;, 5.0)
    endif
    else
    //coldstorm slow effect
    //made by SanKakU so please give credits if you use this spell in your map
    if i == ColdStorm then
    if GetFloatGameState(GAME_STATE_TIME_OF_DAY) &gt;= 18.00 then
    set u = CreateUnit(GetOwningPlayer(GetSpellAbilityUnit()), &#039;e000&#039;, ux, uy, 270.00)
    call UnitAddAbility(u, &#039;A00Y&#039;)
    call SetUnitAbilityLevel(u, &#039;A00Y&#039;, GetUnitAbilityLevel(GetSpellAbilityUnit(),ColdStorm))
    call UnitApplyTimedLife(u, &#039;BTLF&#039;, 5.0)
    endif
    else

i know things are a big mess right now...so please, some experts come along and clean it up for me, ok? you will of course be credited with helping if you do so...i know i'm not an expert programming and i know my place.

i mean...looking over my post...it seems to me like...i'm making a request for this bunch of code i wrote to be transformed into a system...or at least have someone explain to me how to do that, which would be preferable.

UndeadDragon · Nov 27, 2009

Please indent your code. It makes it really difficult to read if it is one block of text.

Also, all of those functions can be put in one trigger, to simplify it a bit.

Zwiebelchen · Nov 28, 2009

What exactly is the point of this system?

kingkingyyk3 · Nov 28, 2009

I reckon it will be graveyard because of your unreadable code.

ElderKingpin · Nov 28, 2009

IM GUESSING. that instead of night turning into day in one quick move. it slowly changes into night and day. like real life (i guess?)

SanKakU · Nov 28, 2009

UndeadDragon...don't whine about me not indenting...i don't like doing that.
as for making it all in one trigger...yeah i'm planning on it. i just haven't figured out how to yet.

Zwiebelchen, the system is to enable day time special abilities.

In warcraft 3, you can normally only enable night time abilities.

That's why there's a nightstalker in DOTA and there is the shadowmeld ability which you can only use at night.

With my system, you can go beyond just adding the night time abilities and also add some day time abilities. Just booleans can't pull this off.

That's why nobody has made any heroes or abilities dependant on if it's day time. I had to skip the 24 hour mark and change 23 to 13, which basically means that Warcraft 3 changes the clock from 24 to 0 at midnight. But things are complicated somewhere along the way, where exactly I forgot...to the point that it's necessary to make the 23 go to 13 and make that time be dawn, so that midnight is an unimportant hour. After all, midnight is not a critical hour, there is no dawn or dusk at that time.

ElderKingpin, that would be an interesting idea, but no, lol.

kingkingyyk3, how is it unreadable? i went to the trouble of adding a lot of comments to make it all more understandable... what's wrong with it? if it hits the graveyard i don't mind...i was kindof hoping someone would look at this and want to fix it up, but if that's not happening then that's the only place for it i reckon...

UndeadDragon · Nov 28, 2009

SanKakU said:
kingkingyyk3, how is it unreadable? i went to the trouble of adding a lot of comments to make it all more understandable... what's wrong with it?

It is not indented. It is common practise to indent your code.

quraji · Nov 28, 2009

I don't really get this. I'm not sure if you're trying to make custom day lengths or only allow abilities during the daytime/nighttime...

If you want to know if it's day, just use this.

JASS:

library DayOrNight

    globals
        real Dawn = 6.
        real Dusk = 18.
    endglobals
    
    function IsDaytime takes nothing returns boolean
        local real t = GetTimeOfDay()
        if (t&gt;=Dawn or t&lt;Dusk) then
            return true
        endif
        return false
    endfunction
    
endlibrary

kingkingyyk3 · Nov 28, 2009

You should make it in a library or post it in form of demo map.

tooltiperror · Nov 28, 2009

The good seams like no one would use it, tbh.

And why not use the above function someone posted?

SanKakU · Nov 28, 2009

quraji said:

I don't really get this. I'm not sure if you're trying to make custom day lengths or only allow abilities during the daytime/nighttime...

If you want to know if it's day, just use this.

JASS:

library DayOrNight

    globals
        real Dawn = 6.
        real Dusk = 18.
    endglobals
    
    function IsDaytime takes nothing returns boolean
        local real t = GetTimeOfDay()
        if (t&gt;=Dawn or t&lt;Dusk) then
            return true
        endif
        return false
    endfunction
    
endlibrary

what don't you understand about "Just booleans can't pull this off."? (rhetorical question, don't answer that)

I DID NOT MAKE THIS SYSTEM TO ARGUE ABOUT WHY IT'S NECESSARY...
I Honestly don't even remember where all the bugs are without me advancing it as far as I did.
But the bugs ARE there.

kingkingyyk3, you're probably right...

Everyone, just ignore the thread for now until I update the original post with something better. I don't want someone else thinking he's so smart coming in here telling me why the system isn't necessary...

Lyerae · Nov 29, 2009

JASS:

library DayOrNight

    globals
        real Dawn = 6.
        real Dusk = 18.
    endglobals
    
    function IsDaytime takes nothing returns boolean
        local real t = GetTimeOfDay()
        if (t&gt;=Dawn or t&lt;Dusk) then
            return true
        endif
        return false
    endfunction
    
endlibrary

->

JASS:

library DayOrNight
function IsDaytime takes nothing returns boolean
        local real t = GetTimeOfDay()
        if (t &gt;= 6.0 or t&lt;18.) then
            return true
        endif
        return false
    endfunction
    
endlibrary

?

NetherHawk · Nov 29, 2009

i have a map i made which there is a hero like night stalker. All i do is check if the time is > 17.99 and < 06.01 , no problems or bugs. What bugs do u get.

JASS:

function IsNight takes nothing returns boolean
    return GetTimeOfDay() &gt; 17.99 or GetTimeOfDay() &lt; 6.01
endfunction

i noticed that if u use exact values like 18.00 or 6.00 sometimes the trigger bugs.

Lyerae · Nov 29, 2009

Actually...

JASS:


function IsTimeDay takes nothing returns nothing
        if (GetTimeOfDay() &gt;= 6.0 or GetTimeOfDay() &lt; 18.) then
            return true
        endif
        return false
endfunction

?

Narks · Nov 29, 2009

two function calls instead of one?

Executor · Nov 29, 2009

Well, an important attribute of systems/librarys is, that the user can actually READ the code and understand it for himself. It is rubbish to tell the users to change function names, because this requires them to understand the code before the modification, which is hardly possible with "... function A ..." etc.

Furthermore would you explain more in detail these aspects:

WHAT does this system do?
HOW can I access these functions?*

*I hope the user doesn't have to write code inside your library, because this is nonprofessional, unhandy and not our standard. Keyword = Interface.

Maybe you should remember that this section is for finished systems only. If you want to improve your system post it in "JASS Help".

And for god's sake, learn to FORMAT your code...

Did you want to do sth. like this?

JASS:

library DayAndNight initializer Init
    globals
        private constant real DUSK = 18.
        private constant real DAWN =  6.
    endglobals    
       
    globals
        private Event   DayToNight      = 0
        private Event   NightToDay      = 0
        private trigger OnDayToNight    = CreateTrigger()
        private trigger OnNightToDay    = CreateTrigger()
    endglobals
    
    function IsDay takes nothing returns boolean
        local real time = GetFloatGameState(GAME_STATE_TIME_OF_DAY)
        return time &gt;= DAWN and time &lt;= DUSK
    endfunction
    
    function IsNight takes nothing returns boolean
        local real time = GetFloatGameState(GAME_STATE_TIME_OF_DAY)
        return time &lt; DAWN or time &gt; DUSK
    endfunction
    
    function TriggerRegisterDayBecomesNight takes trigger t returns EventReg
        return DayToNight.register(t)
    endfunction 
    
    function TriggerRegisterNightBecomesDay takes trigger t returns EventReg
        return NightToDay.register(t)
    endfunction 
    
    private function OnDayToNightEx takes nothing returns boolean
        call DayToNight.fire()
        return false
    endfunction
    
    private function OnNightToDayEx takes nothing returns boolean
        call NightToDay.fire()
        return false
    endfunction
    
    private function Init takes nothing returns nothing
        set DayToNight = Event.create()
        set NightToDay = Event.create()
        
        call TriggerRegisterGameStateEvent(OnDayToNight, GAME_STATE_TIME_OF_DAY, EQUAL, DUSK)
        call TriggerRegisterGameStateEvent(OnNightToDay, GAME_STATE_TIME_OF_DAY, EQUAL, DAWN)
        call TriggerAddCondition(OnDayToNight, Condition( function OnDayToNightEx))
        call TriggerAddCondition(OnNightToDay, Condition( function OnNightToDayEx))
    endfunction
endlibrary

JASS:

scope LifeLeechInNightSpell initializer Init
    globals
        private             group       GROUP           = CreateGroup()
    
        private constant    integer     ID_UNIT         = &#039;abcd&#039;
        private constant    integer     ID_SPELL        = &#039;efgh&#039;
        private             trigger     onTimeChange    = CreateTrigger()
        
        private             boolean     Day
        private             boolexpr    AddAndRemoveLifeLeech
    endglobals
    
    private function FAddAndRemoveLifeLeech takes nothing returns boolean
        local unit u = GetFilterUnit()
        if GetUnitTypeId(u) != ID_UNIT then
            return false
        endif
        
        if Day then
            call UnitRemoveAbility(u,ID_SPELL)
        else
            call UnitAddAbility(u,ID_SPELL)
        endif        
        return false
    endfunction

    private function onTimeChangeEx takes nothing returns boolean
        set Day = IsDay()
        call GroupEnumUnitsInRect(GROUP,bj_mapInitialPlayableArea,AddAndRemoveLifeLeech)
        return false
    endfunction
    
    private function Init takes nothing returns nothing
        call TriggerRegisterDayBecomesNight(onTimeChange)
        call TriggerRegisterNightBecomesDay(onTimeChange)
        call TriggerAddCondition(onTimeChange, Condition( function onTimeChangeEx))
        set AddAndRemoveLifeLeech = Condition( function FAddAndRemoveLifeLeech)
        call onTimeChangeEx()
    endfunction
endscope

quraji · Nov 29, 2009

SanKakU said:
what don't you understand about "Just booleans can't pull this off."? (rhetorical question, don't answer that)

Apparently, the "booleans can't pull this off" part.

JASS:


scope MyDaytimeSpell
...
private function GetDamageOrWhatever takes nothing returns real
    if (IsDaytime()) then
        return 100.
    endif
    return 50.
endfunction
...
endscope

SanKakU said:
I DID NOT MAKE THIS SYSTEM TO ARGUE ABOUT WHY IT'S NECESSARY...

But you did post it, so you get our opinions/comments/criticisms.

SanKakU said:
I Honestly don't even remember where all the bugs are without me advancing it as far as I did.
But the bugs ARE there.

I believe you..

SanKakU said:
I don't want someone else thinking he's so smart coming in here telling me why the system isn't necessary...

I'm still not clear what the heck it is or what it's supposed to do.
Clean it up, follow the advice of what people have been saying. If you need help ask for it.

SanKakU · Nov 29, 2009

Executor said:

Well, an important attribute of systems/librarys is, that the user can actually READ the code and understand it for himself. It is rubbish to tell the users to change function names, because this requires them to understand the code before the modification, which is hardly possible with "... function A ..." etc.

Furthermore would you explain more in detail these aspects:

WHAT does this system do?
HOW can I access these functions?*

*I hope the user doesn't have to write code inside your library, because this is nonprofessional, unhandy and not our standard. Keyword = Interface.

Maybe you should remember that this section is for finished systems only. If you want to improve your system post it in "JASS Help".

And for god's sake, learn to FORMAT your code...

Did you want to do sth. like this?

JASS:

library DayAndNight initializer Init
    globals
        private constant real DUSK = 18.
        private constant real DAWN =  6.
    endglobals    
       
    globals
        private Event   DayToNight      = 0
        private Event   NightToDay      = 0
        private trigger OnDayToNight    = CreateTrigger()
        private trigger OnNightToDay    = CreateTrigger()
    endglobals
    
    function IsDay takes nothing returns boolean
        local real time = GetFloatGameState(GAME_STATE_TIME_OF_DAY)
        return time &gt;= DAWN and time &lt;= DUSK
    endfunction
    
    function IsNight takes nothing returns boolean
        local real time = GetFloatGameState(GAME_STATE_TIME_OF_DAY)
        return time &lt; DAWN or time &gt; DUSK
    endfunction
    
    function TriggerRegisterDayBecomesNight takes trigger t returns EventReg
        return DayToNight.register(t)
    endfunction 
    
    function TriggerRegisterNightBecomesDay takes trigger t returns EventReg
        return NightToDay.register(t)
    endfunction 
    
    private function OnDayToNightEx takes nothing returns boolean
        call DayToNight.fire()
        return false
    endfunction
    
    private function OnNightToDayEx takes nothing returns boolean
        call NightToDay.fire()
        return false
    endfunction
    
    private function Init takes nothing returns nothing
        set DayToNight = Event.create()
        set NightToDay = Event.create()
        
        call TriggerRegisterGameStateEvent(OnDayToNight, GAME_STATE_TIME_OF_DAY, EQUAL, DUSK)
        call TriggerRegisterGameStateEvent(OnNightToDay, GAME_STATE_TIME_OF_DAY, EQUAL, DAWN)
        call TriggerAddCondition(OnDayToNight, Condition( function OnDayToNightEx))
        call TriggerAddCondition(OnNightToDay, Condition( function OnNightToDayEx))
    endfunction
endlibrary

JASS:

scope LifeLeechInNightSpell initializer Init
    globals
        private             group       GROUP           = CreateGroup()
    
        private constant    integer     ID_UNIT         = &#039;abcd&#039;
        private constant    integer     ID_SPELL        = &#039;efgh&#039;
        private             trigger     onTimeChange    = CreateTrigger()
        
        private             boolean     Day
        private             boolexpr    AddAndRemoveLifeLeech
    endglobals
    
    private function FAddAndRemoveLifeLeech takes nothing returns boolean
        local unit u = GetFilterUnit()
        if GetUnitTypeId(u) != ID_UNIT then
            return false
        endif
        
        if Day then
            call UnitRemoveAbility(u,ID_SPELL)
        else
            call UnitAddAbility(u,ID_SPELL)
        endif        
        return false
    endfunction

    private function onTimeChangeEx takes nothing returns boolean
        set Day = IsDay()
        call GroupEnumUnitsInRect(GROUP,bj_mapInitialPlayableArea,AddAndRemoveLifeLeech)
        return false
    endfunction
    
    private function Init takes nothing returns nothing
        call TriggerRegisterDayBecomesNight(onTimeChange)
        call TriggerRegisterNightBecomesDay(onTimeChange)
        call TriggerAddCondition(onTimeChange, Condition( function onTimeChangeEx))
        set AddAndRemoveLifeLeech = Condition( function FAddAndRemoveLifeLeech)
        call onTimeChangeEx()
    endfunction
endscope

well i don't entirely understand your code but it might have something to it.

as for the others that still are wondering about where the errors come about...i don't remember the details but i think i just remembered that a big problem is with event registration.

if i remember right, i couldn't figure out how to get the event registering to fire properly without doing what i did. i'm not sure if what Executor proposed would fix it or not, but i'll definitely check it out...

as far as i can figure, if i'm remembering this right...
you can't get an event registered for time of day becomes greater than such and such and less than such and such. you can boolean it to figure out what time it is, but that's all you can do. you still need the proper event registration to begin with.

if you cast a spell, it's an easy matter to check the time right? but what if you need to replace the entire spell with another spell? the event isn't going to be when you cast the spell, it's going to be when the time goes from day to night or vice versa. that's the key, and that's why the system is important. it sounds like Executor might understand this, I'm not sure(it kinda looks like he just posted a lot of functions that call eachother, but what do i know...he didn't add any comments)...i copied his code into a trigger and i'll check it out later.

Jesus4Lyf · Nov 29, 2009

His code requires Event.

But it is just an Event wrapper. What's wrong with...

JASS:

        call TriggerRegisterGameStateEvent(OnDayToNight, GAME_STATE_TIME_OF_DAY, EQUAL, DUSK)
        call TriggerRegisterGameStateEvent(OnNightToDay, GAME_STATE_TIME_OF_DAY, EQUAL, DAWN)

I can do this in GUI.

Sevion · Nov 29, 2009

Hold on, I don't get why we need so much code for something so simple?

System Custom Day and Night System

Member

Super Moderator

You can change this now in User CP.

Visitor (Welcome to the Jungle, Baby!)

Post in the anime section, or die.

Member

Super Moderator

zap

Visitor (Welcome to the Jungle, Baby!)

Super Moderator

Member

I keep popping up on this site from time to time.

New Member

I keep popping up on this site from time to time.

Vastly intelligent whale-like being from the stars

I see you

zap

Member

Good Idea™

The DIY Ninja

Log in

The Helper Discord

Share this page

Affiliates

Network Sponsors