System Timer32

[Kenny]

>Also, the name "next" and "prev" could conflict with other stuff... <_< any ideas for that issue? Or is that unlikely.

That was my biggest concern as well... That is where operators come in handy, but I don't think giving them an absurd name is going to be all that good.

It is unlikely that they will ever be used, so maybe even a T32_next or T32_getNext() or something. That way, although they are there, they will not conflict with anything, and it isn't something that someone will just type. They will only be there for people who know about them and understand their usage.

 

[kingkingyyk3]

    private function OnExpire takes nothing returns boolean
        set Tick=Tick+1
        return false
    endfunction
    
    private function OnInit takes nothing returns nothing
        call TriggerRegisterTimerEvent(Trig,PERIOD,true)
        call TriggerAddCondition(Trig,Condition(function OnExpire))
    endfunction

?

 

[Jesus4Lyf]

Thought of that. Is it faster?
Clashes oddly with struct initialisers, and figured the efficiency was the same, so I didn't do that.

 

[Azlier]

Just here to say that this is handy.

method periodic takes nothing returns nothing
    set Size = Size - 0.05
    call SetUnitScale(Burrow, Size, 0, 0)
    if Size == 0 then
        set Size = 1
        call stopPeriodic()
    endif
endmethod

 

[Troll-Brain]

I fail to make a test where it proofs that thing is more efficient than using X timers instead.
Maybe internally timers are already handle like that ?

It starts to lag not because one or the other method, but just because of the tested code itself.

Maybe my pc is to much performant for a such test.
I understand that the API is neater here than just TimerUtils, though.

Could someone provide me an example where T32 is more efficient than using TimerUtils with X timers, plz ?

 

[kingkingyyk3]

KT2 is better than TimerUtils in short period(see the benchies). T32 is more efficient than KT2.

 

[Troll-Brain]

KT2 is better than TimerUtils in short period(see the benchies).

There is absolutely not any benchmark code shared, in the whole 8 pages of this thread.

 

[Sickle]

However, there are plenty of benchmarks in the KT2 thread. And since T32 is a hardcoded KT2 period, logically it is faster. But, alas, logic does not work with Blizzard.

 

[kingkingyyk3]

Do you mind to share you benchmark code for T32?

 

[Jesus4Lyf]

T32 compared to?

 

[kingkingyyk3]

T32 vs T32x

 

[Romek]

The speeds are the same, the core system is identical.
The only difference is the method of stopping the executions.

 

[Jesus4Lyf]

That's not true, actually. Look carefully:
T32:

function Periodic takes integer i returns boolean
    if condition then // if/then.
        return true
    endif
    return false
endfunction
private function PeriodicLoop takes nothing returns boolean
    local thistype this=thistype(0).next
    loop
        exitwhen this==0
        if this.periodic() then // another if/then.
            // This is some real magic.
            set this.prev.next=this.next
            set this.next.prev=this.prev
            // This will even work for the starting element.
            debug set this.prev=0
        endif
        set this=this.next
    endloop
    return false
endmethod

T32x:

function Periodic takes integer i returns nothing
    if condition then
        call this.stopPeriodic()
    endif
endfunction
private function PeriodicLoop takes nothing returns boolean
    local thistype this=thistype(0).next
    loop
        exitwhen this==0
        call this.periodic() // no second if statement.
        set this=this.next
    endloop
    return false
endmethod

T32x should be faster. Faster again, if you used a .ticks value and switch to .endTick and use T32_Tick.

But I haven't benchmarked T32x yet.

 

[Hatebreeder]

shouldn't this [ljass] call TimerStart(CreateTimer(),PERIOD,true,function OnExpire) [/ljass] leak?

 

[Trollvottel]

shouldn't this [ljass] call TimerStart(CreateTimer(),PERIOD,true,function OnExpire) [/ljass] leak?

nope, why should it? you can refer to the timer in the expiration function, but you dont even need that.

 

[Romek]

> That's not true, actually. Look carefully:
Yes, it's pretty much the same.
The stuff within the 'if' in the periodic loop has simply been moved to another function.

 

[GoGo-Boy]

I got a problem with your system.

It seems that certain frequencies make the system go malfunctioning.
I have this one function for camera movement that runs every 0.02 seconds. Now if I set the value to 0.015 the function stops running after some time, I think especially when I used other spells that include KT.
I wondered what could possibly be the issue and added a debug msg each time the function runs. And yeah as I thought for the 0.015 frequency the function just doesn't run anymore after using other spells or whatever including KT.
And all I change is the goddamn frequency!

 

[Jesus4Lyf]

You need to post code. I highly doubt it's a system issue. I run it on 0.0 sec period for benchmarking.

Err, hang on. Are you in the right thread? You're talking a lot about KT there.

 

[GoGo-Boy]

Ahh crap you're right, ment to be in they Key Timers 2 thread. Sorry :/

 

[Nexor]

I'm working on a map that uses currently about 10-12 spells, and the 70% of it uses T32.
There are some problems with it, sometimes the debugmessages are displayed but I don't see any reason why it should be displayed.

Here's an example:

private struct slow
    unit hero
    integer ticks
    integer stacks
    
    method periodic takes nothing returns boolean
        local unit u
        set .ticks = .ticks - 1
        if .ticks == 0 or .stacks == 0 then
            set .ticks = T32_FPS
            set .stacks = .stacks + 1
            call UnitRemoveAbility(.hero,BuffID)
            set u = CreateUnit(Player(PLAYER_NEUTRAL_PASSIVE),'dumy',GetUnitX(.hero),GetUnitY(.hero),0)
            call UnitAddAbility(u,SlowID)
            call SetUnitAbilityLevel(u,SlowID,.stacks)
            call UnitApplyTimedLife(u,'BTLF',1.)
            call IssueTargetOrder(u,"slow",.hero)
            set u = null
        elseif .stacks == 9 then
            set u = null
            return true
        endif
        return false
    endmethod
    
    implement T32
endstruct



private function onCast takes unit u returns nothing
    local slow S =  slow.create()
    
    set S.hero = u
    set S.stacks = 0
    set S.ticks = T32_FPS
    
    call S.startPeriodic()
    
endfunction

I see that it has been updated, what should I do to make it work with T32x?